Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes in "Options" Tab are not applied #110

Open
dilasa opened this issue Aug 28, 2017 · 4 comments
Open

changes in "Options" Tab are not applied #110

dilasa opened this issue Aug 28, 2017 · 4 comments
Assignees

Comments

@dilasa
Copy link

dilasa commented Aug 28, 2017

TrackMeNot Version 0.10.2
Firefox 55.0.3 (64-Bit)
WIndows 10

First: I can only remove search engine entries one by one, i have to close and reopen the "Options" Tab to see my changes. But when i then close Firefox and reopen it, everything is in initial mode, so again all search engine entries show up.

Second: When i check the "Generate queries including keywords monitored by DHS" and then press "Apply" close and reopen the "Options" Tab it is not checked anymore.

@DidierLmn
Copy link

TrackMeNot Version 0.10.2
Firefox 57 (64-bit)
MacOS 10.12.6

The "Generate queries including keywords monitored by DHS" does not remain checked for me either.

@vtoubiana
Copy link
Owner

I'll start looking at this. @DidierLmn Do you also have the same with respect to search engine deletion?

Thank you for reporting.

Vincent

@DidierLmn
Copy link

Thanks for the follow-up @vtoubiana .
I hadn't try that yet, but have done so now.

I'm able to remove multiple search-engines at once, however the changes also don't appear until I reopen the 'options' tab, and quitting Firefox and restarting also reverts the changes with me as well.

@DidierLmn
Copy link

About the DHS-option, I've tried to find the issue, but I'm not that familiar with Firefox Add-ons and haven't been able to find the issue.

However I can tell you it isn't in option-script.js on line 215 (function saveOptions()) the options variable that gets returned there gets the right value.

screenshot

But if I then look at the localstorage, the value is still false, so maybe there's something wrong with the function that writes to local-storage?

screenshot2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants