Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump event-stream version to remove flatmap-stream dependency #451

Closed
pedro823 opened this issue Dec 11, 2018 · 1 comment
Closed

Bump event-stream version to remove flatmap-stream dependency #451

pedro823 opened this issue Dec 11, 2018 · 1 comment

Comments

@pedro823
Copy link
Member

tl;dr: There is a backdoored dependency on VTEX toolbelt that has malicious code. This does not affect VTEX in specific, however this should be removed anyway. This is important -- It could have been targeted toward VTEX.

On line 2379 of yarn.lock:

flatmap-stream@^0.1.0:
  version "0.1.1"
  resolved "https://registry.yarnpkg.com/flatmap-stream/-/flatmap-stream-0.1.1.tgz#d34f39ef3b9aa5a2fc225016bd3adf28ac5ae6ea"

this is the exact dependency, exact version, that contains malicious code. Version 0.1.2 doesn't have malicious code, and was completely removed by event-stream in the latest version.

For complete information of what that code did, read this article.

Mentioning the original issues of the backdoored code:

dominictarr/event-stream#116
dominictarr/event-stream#115

Possible Solution

Update the dependencies to fully remove the malicious code.

@ghost
Copy link

ghost commented Jan 4, 2019

hi

@pedro823 pedro823 closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant