Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button in-line styling does not apply #1341

Closed
oviolion opened this issue Oct 13, 2020 · 2 comments
Closed

Button in-line styling does not apply #1341

oviolion opened this issue Oct 13, 2020 · 2 comments

Comments

@oviolion
Copy link

Describe the bug
You cannot add in-line styling to the component

To Reproduce
<Button style={{ margin: 8 }} /> doesn't add any margin

Expected behavior
<Button style={{ margin: 8 }} /> should add margin: 8px any margin

@kevinch
Copy link
Contributor

kevinch commented Oct 15, 2020

Hey @oviolion thanks for the report.
Indeed our components do not accept any kind of customisation and that's by design. Since this styleguide is mostly used with our admin apps, we wanted at the time to limit the customisation to ensure consistency and not risk strange stylings. We've learned along the way and realised that this was not necessarily the best approach but since the whole styleguide is built that way, this refactor would be too much work to handle. I suggest to wrap your component within a parent div for example and apply the margin on this one.
Thanks.

@kevinch kevinch closed this as completed Oct 15, 2020
@oviolion
Copy link
Author

Thought so, thank you for the explanation 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants