Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] disable options #1150

Closed
igorbrasileiro opened this issue Apr 6, 2020 · 4 comments · Fixed by #1275
Closed

[Menu] disable options #1150

igorbrasileiro opened this issue Apr 6, 2020 · 4 comments · Fixed by #1275
Labels
💻 Dev needed This issue needs a friendly developer to implement it. ✨ Enhancement Next Major

Comments

@igorbrasileiro
Copy link

igorbrasileiro commented Apr 6, 2020 •
edited
Loading

Purpose

Disable the Menu component options.
Tabs component use Menu to handle collapsed tabs, but some tabs can be disabled and the Menu component don't disable options.

Context

Menu with last 3 months option disabled
image

Examples

Another library that implements a disabled menu option is Material UI menus.
@jonathasbsouza
Copy link
Contributor

We could create an isDisabled prop, disabling click, and using the CSS tokens for disabled items.

@estacioneto
Copy link
Contributor

@jonathasbsouza
Copy link
Contributor

Thanks @estacioneto! I'm a noob in this dev world hahaha :)

@jonathasbsouza
Copy link
Contributor

I think it's clear for everybody the design solution here. I'll remove the Design Needed label and wait for someone to solve this issue.

@jonathasbsouza jonathasbsouza added 💻 Dev needed This issue needs a friendly developer to implement it. and removed Design Needed labels May 16, 2020
@vlaux vlaux mentioned this issue Jul 10, 2020
Merged
4 tasks
@vlaux vlaux linked a pull request Jul 10, 2020 that will close this issue
Add disabled prop to ActionMenu items #1275
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 Dev needed This issue needs a friendly developer to implement it. ✨ Enhancement Next Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add disabled prop to ActionMenu items vtex/styleguide
3 participants
@jonathasbsouza @igorbrasileiro @estacioneto