Skip to content

user prompts sometimes do not show due to browser restrictions. #63

Description

@Josverl

Describe the bug

user prompts sometimes do not show - mostly in embedded browsers , or other browser configured to suppress prompts.

Setup

  • MicroPython board: Any
  • MicroPython version: Any
  • OS version: Windows
  • Browser: Embedded - VSCode integrated browser
  • Connection type: Any

To Reproduce

  • use ViperIDE in an embedded browser such as the VSCode Integrated browser
  • connect to any board
  • Settings > Tools> click Install Package

Expected behavior

A Prompt to appear

Actual Screenshots / Logs
A red error dialog in right top corner

There are multiple places other places that use similar code :

  • File creation
  • WebRepl connection
  • Some of the 2ndary pages banchmark.html, bridge.html
  • The MCP server monkeypatches window.prompt to be able to control the input.
utils.js:119 Error Error: Error: prompt() is not supported.
at utils_browser.js:318:21 Error: Error: prompt() is not supported.
at http://localhost:10001/app.js:49592:21
report @ utils.js:119
(anonymous) @ utils_browser.js:318

Additional context
Mostly relevant for the Developer experience - less likely to occur for users

On the up-side: Fixing this would allow for a better/controllable/themable dialog to be offered to end-users

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions