Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associates files with .pp extension to puppet #400

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Associates files with .pp extension to puppet #400

merged 1 commit into from
Oct 24, 2016

Conversation

csprabala
Copy link

@csprabala csprabala commented Oct 20, 2016 •
edited
Loading

**Fixes #399 **

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix - Associate files with .pp extension to puppet

Things I've done:

  • I've pulled the latest master branch
  • I've run npm install to install all the dependenies
  • I've checked my code, it is clean.
  • I've run ESLint.
  • My pull request fixes an issue, I referenced the issue.
  • My pull request is not too big, otherwise I've already squashed it.
  • I've run npm run build to build the extension. (If I had done something with the extension.)

@jens1o
Copy link
Member

jens1o commented Oct 20, 2016

Thanks! Looking good!

@robertohuertasm robertohuertasm merged commit a459122 into vscode-icons:master Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please associate .pp extension with puppet.
3 participants
@csprabala @jens1o @robertohuertasm