Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview didn't display bold on non-english , and Front Matter #696

Open
bluelovers opened this issue Feb 1, 2019 · 5 comments
Open

preview didn't display bold on non-english , and Front Matter #696

bluelovers opened this issue Feb 1, 2019 · 5 comments

Comments

@bluelovers
Copy link

  • preview didn't display bold on non-english char
  • preview didn't display Front Matter <== don't care this one, just saying

image

@vsch
Copy link
Owner

vsch commented Feb 1, 2019

@bluelovers, you need to specify a font which has bold weight implemented. JavaFX will only display bold if it is available. Issue #533 talks about changing fonts for PDF but the same fonts will work for preview if the settings are changed.

I have not tried using Google Noto fonts for preview. For PDF they don't work but for preview they might.

The front matter rendering in preview is on the todo list and will be available soon.

@vsch
Copy link
Owner

vsch commented Feb 1, 2019

@bluelovers, front matter is a non-rendering component. Any preferences or ideas that you saw in other implementations that render the front matter would be appreciated.

@vsch
Copy link
Owner

vsch commented Feb 1, 2019

@bluelovers, if you have a free font that you could recommend I would appreciate it.

I want to add a feature to download and install CJK fonts for plugin use. I cannot bundle them because of excessive size. The fonts are bigger than the plugin.

@bluelovers
Copy link
Author

the font can't follow (os or idea) setting?

if can, i think it will better then ember font into plugin, because there has too many lang font

@vsch
Copy link
Owner

vsch commented Feb 2, 2019

@bluelovers, on considering our discussion and all the support questions regarding fonts, I will add Stylesheet settings that will facilitate adding fonts definitions to the stylesheet without having to know the details. Just a list of additional font file paths and whether they should be added to body or to code styles (for monospaced fonts).

I don't know if it will make it into the next official release because it is already late and the list of fixes and features is already huge. The fix will definitely make it into an EAP release shortly after the official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants