Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slack_icon docs to README #497

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Add slack_icon docs to README #497

merged 3 commits into from
Jun 28, 2019

Commits on Jun 20, 2019

  1. Add slack_icon docs to README

    @ncstate-mafields
    ncstate-mafields committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    80a0610 View commit details
    Browse the repository at this point in the history

  2. Add default value for slack_icon to match hardcoded fallback

    @ncstate-mafields
    ncstate-mafields committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    eeaf999 View commit details
    Browse the repository at this point in the history

  3. Revert default slack_icon value to undef 

    Setting the default value breaks all the tests. Having a defined
default value is more of a clarity in config thing than a
functional requirement, since the code will fall back to the
hardcoded ":ocean:" value if the value is undefined.
    @ncstate-mafields
    ncstate-mafields committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    e0c9b7d View commit details
    Browse the repository at this point in the history