Wrap slack_icon with colons #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration file for the webhook config writes values that begin with colons (:) as symbols rather than strings, to allow for calculated values. Since slack emoji names follow the pattern of `:name:`, they are written as symbols instead of strings, and the resulting config file breaks the webhook service. This change simply requires slack icons to be entered without the wrapping colons, and adds them back just before sending to Slack. Where previously the ocean icon would be written as `:ocean:` in the webhook_slack_icon parameter, now it would be written as `ocean`.
Merged
|
Does this deserve a little disclaimer somewhere in the docs, so people know to adjust? |
|
I don't think the I can use this PR to update the docs to include the |
|
Since it was not documented already, I went ahead and merged it prior to 7.0.0, but please do open a documentation PR when you get a chance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The configuration file for the webhook config writes values that
begin with colons (:) as symbols rather than strings, to allow
for calculated values.
Since slack emoji names follow the pattern of
:name:, they arewritten as symbols instead of strings, and the resulting config
file breaks the webhook service.
This change simply requires slack icons to be entered without the
wrapping colons, and adds them back just before sending to Slack.
Where previously the ocean icon would be written as
:ocean:inthe webhook_slack_icon parameter, now it would be written as
ocean.This Pull Request (PR) fixes the following issues
n/a