Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using exec in run_command replaces process and skips notify_* calls #441

Closed
legooolas opened this issue Jul 10, 2018 · 1 comment · Fixed by #485
Closed

Using exec in run_command replaces process and skips notify_* calls #441

legooolas opened this issue Jul 10, 2018 · 1 comment · Fixed by #485

Comments

@legooolas
Copy link

The run_command function uses exec with a backgrounded command (using &) to run the desired command, which cannot get the exit status of the command, and also replaces the running webhook binary (forked from the parent) with this command.

This means that anything expected to run after calling run_command no longer works.

Not sure if the affected Puppet, Ruby, OS etc versions are required, but here's what I'm using currently:

  • Puppet : 4.10.12
  • Ruby : 2.1.9p490 (provided by Puppet PC1 install)
  • Distribution : CentOS 7.5
  • Module version : 6.6.0 (latest at time of writing)

How to reproduce:

  • Use slack notifications and upgrade to puppet-r10k 6.6.0

What are you seeing:

  • No Slack notifications of r10k updates

Expected behaviour:

  • Slack notifications of r10k run with success/failure status
@stanleyz
Copy link

stanleyz commented Nov 16, 2018

#458
I fixed that in #458 waiting for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants