Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the log output when deleting a branch #374

Closed
rnelson0 opened this issue May 30, 2017 · 0 comments
Closed

Clean up the log output when deleting a branch #374

rnelson0 opened this issue May 30, 2017 · 0 comments

Comments

@rnelson0
Copy link
Member

When deleting a branch, access.log shows content like this:

[2017-05-30 13:36:43] DEBUG accept: $IP:54632
[2017-05-30 13:36:43] DEBUG Rack::Handler::WEBrick is invoked.
[2017-05-30 13:36:43] INFO  Authenticated as user puppet from IP $IP
[2017-05-30 13:36:45] ERROR message:
WARN     -> Both /etc/puppetlabs/r10k/r10k.yaml and /etc/r10k.yaml configuration files exist.
WARN     -> /etc/puppetlabs/r10k/r10k.yaml will be used.
ERROR    -> Environment(s) 'test' cannot be found in any source and will not be deployed.
INFO     -> Removing unmanaged path /etc/puppetlabs/puppet/environments/test
 trace: ["/usr/local/bin/webhook:229:in `block in run_command'", "/usr/local/bin/webhook:215:in `open'", "/usr/local/bin/webhook:215:in `run_command'", "/usr/local/bin/webhook:332:in `deploy'", "/usr/local/bin/webhook:173:in `block in <class:Server>'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `block in compile!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `[]'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (3 levels) in route!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:994:in `route_eval'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (2 levels) in route!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1015:in `block in process_route'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `catch'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `process_route'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:973:in `block in route!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `each'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `route!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1085:in `block in dispatch!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1082:in `dispatch!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `block in call!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `call!'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:895:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-1.6.4/lib/rack/nulllogger.rb:9:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-1.6.4/lib/rack/head.rb:13:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/show_exceptions.rb:25:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:182:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:2013:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `block in call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1787:in `synchronize'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `call'", "/opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/rack-1.6.4/lib/rack/handler/webrick.rb:88:in `service'", "/opt/puppetlabs/puppet/lib/ruby/2.1.0/webrick/httpserver.rb:138:in `service'", "/opt/puppetlabs/puppet/lib/ruby/2.1.0/webrick/httpserver.rb:94:in `run'", "/opt/puppetlabs/puppet/lib/ruby/2.1.0/webrick/server.rb:295:in `block in start_thread'"]
[2017-05-30 13:36:47] DEBUG close: $IP:54632

Line 229 in my install corresponds with L238 and the non-zero exit_status when L332 is invoked. This bails out and ends up in the rescue branch. I modified my webhook temporarily to verify the command run and see the actual error it throws:

# tail -f access.log 
[2017-05-30 14:10:01] DEBUG accept: 135.28.170.140:60841
[2017-05-30 14:10:01] DEBUG Rack::Handler::WEBrick is invoked.
[2017-05-30 14:10:01] INFO  Authenticated as user puppet from IP 135.28.170.140
[2017-05-30 14:10:01] INFO  command: umask 0022; r10k deploy environment test -pv branch: test
[2017-05-30 14:10:03] ERROR message:
ERROR    -> Environment(s) 'test' cannot be found in any source and will not be deployed.
INFO     -> Removing unmanaged path /etc/puppetlabs/puppet/environments/test
 trace: ...

# umask 0022; r10k deploy environment test -pv
ERROR    -> Environment(s) 'test' cannot be found in any source and will not be deployed.
# echo $?
1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant