Webhook not compatible with Puppet 4.10.0

[dhollinger]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 4.10.0
• Ruby: 2.9.1p490 (included with AIO package)
• Distribution: CentOS 7.3.1611
• Module version: 5.0.1

How to reproduce (e.g Puppet code you use)

  class { 'r10k::webhook':
    user  => $pmaster_profile::r10k_web_user,
    group => $pmaster_profile::r10k_web_grp,
  }

  class { 'r10k::webhook::config':
    use_mcollective  => $pmaster_profile::r10k_web_mco,
    public_key_path  => $pmaster_profile::r10k_web_pub,
    private_key_path => $pmaster_profile::r10k_web_priv,
  }

What are you seeing

the webhook.bin.erb template is checking is_pe and puppetversion to set the ruby path in
the webhook bin file. On Puppet 4.10.0 and above, it does NOT match on @puppetversion >= '4.2.0' causing the ruby path to be set to /usr/bin/ruby instead of /opt/puppetlabs/puppet/bin/ruby.

This is causing the webhook to not start on CentOS 7.3.1611

What behaviour did you expect instead

The webhook bin ruby path should be set to /opt/puppetlabs/puppet/bin/ruby and the service should start.

Output log

Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for puppetserver-dev.example.com
Info: Applying configuration version '1491510807'
Notice: /Stage[main]/R10k::Webhook/File[webhook_bin]/content:
--- /usr/local/bin/webhook	2017-04-06 15:11:01.331435805 -0500
+++ /tmp/puppet-file20170406-6177-6l396s	2017-04-06 15:33:31.364793217 -0500
@@ -1,4 +1,4 @@
-#!/opt/puppetlabs/puppet/bin/ruby
+#!/usr/bin/ruby
 # This mini-webserver is meant to be run as the peadmin user
 # so that it can call mcollective from a puppetmaster
 # Authors:

Info: Computing checksum on file /usr/local/bin/webhook
Info: FileBucket got a duplicate file {md5}9cdd8f63f0272f61b90c40a6e4ee5e1d
Info: /Stage[main]/R10k::Webhook/File[webhook_bin]: Filebucketed /usr/local/bin/webhook to puppet with sum 9cdd8f63f0272f61b90c40a6e4ee5e1d
Notice: /Stage[main]/R10k::Webhook/File[webhook_bin]/content:

Notice: /Stage[main]/R10k::Webhook/File[webhook_bin]/content: content changed '{md5}9cdd8f63f0272f61b90c40a6e4ee5e1d' to '{md5}30cc5b66918c745c140b56374312b8c3'
Info: /Stage[main]/R10k::Webhook/File[webhook_bin]: Scheduling refresh of Service[webhook]
Error: /Stage[main]/R10k::Webhook/Service[webhook]: Failed to call refresh: Systemd restart for webhook failed!
journalctl log for webhook:
-- Logs begin at Thu 2017-04-06 15:01:46 CDT, end at Thu 2017-04-06 15:33:31 CDT. --
Apr 06 15:33:31 puppetserver-dev systemd[6300]: Failed at step EXEC spawning /usr/local/bin/webhook: No such file or directory
Apr 06 15:33:31 puppetserver-dev systemd[1]: webhook.service: control process exited, code=exited status=203
Apr 06 15:33:31 puppetserver-dev systemd[1]: Failed to start R10K Webhook Service.
Apr 06 15:33:31 puppetserver-dev systemd[1]: Unit webhook.service entered failed state.
Apr 06 15:33:31 puppetserver-dev systemd[1]: webhook.service failed.

Error: /Stage[main]/R10k::Webhook/Service[webhook]: Systemd restart for webhook failed!
journalctl log for webhook:
-- Logs begin at Thu 2017-04-06 15:01:46 CDT, end at Thu 2017-04-06 15:33:31 CDT. --
Apr 06 15:33:31 puppetserver-dev systemd[6300]: Failed at step EXEC spawning /usr/local/bin/webhook: No such file or directory
Apr 06 15:33:31 puppetserver-dev systemd[1]: webhook.service: control process exited, code=exited status=203
Apr 06 15:33:31 puppetserver-dev systemd[1]: Failed to start R10K Webhook Service.
Apr 06 15:33:31 puppetserver-dev systemd[1]: Unit webhook.service entered failed state.
Apr 06 15:33:31 puppetserver-dev systemd[1]: webhook.service failed.

Notice: Applied catalog in 6.29 seconds

Any additional information you'd like to impart