Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook issues for init service without hasstatus=> false #188

Closed
esalberg opened this issue Jun 8, 2015 · 6 comments
Closed

Webhook issues for init service without hasstatus=> false #188

esalberg opened this issue Jun 8, 2015 · 6 comments

Comments

@esalberg
Copy link

esalberg commented Jun 8, 2015

I just upgraded to the latest version of the module in conjunction with upgrading to PE 3.8 (staying with the module for the webhook, etc.).

The webhook seems to stop and start fine by hand. However, Puppet tries to start the service every time. If I try to get the status by hand, I get a segfault, e.g.::

[root@linvm2153-1 webhook]# service webhook status
/sbin/service: line 66: 28699 Segmentation fault (core dumped) env -i PATH="$PATH" TERM="$TERM" "${SERVICEDIR}/${SERVICE}" ${OPTIONS}

I did some digging into pull requests and noticed that the hassstatus => false parameter was removed due to adding systemd support. Should that be added back in for systems using init, or at least as an option, or is should the status command work and disabling status is hiding an underlying issue?

Pull request referenced:
https://github.com/acidprime/r10k/pull/178

@tampakrap
Copy link
Contributor

I'm pretty sure I tested the initscript as well before submitting that PR, I'll re-test and will report back

@ayohrling
Copy link
Contributor

Can confirm on my end this is still happening, I'm attempting to run down the seg fault issue now.

RHEL 6.6 system is what I'm working on as well.

@ayohrling
Copy link
Contributor

The function status needs to be called whstatus (or something not 'status') because it is causing conflicts when attempting to call the functions version of status. That's the other reason the segfault is occurring.

I am putting together a change and a PR to push in a moment.

@ayohrling
Copy link
Contributor

Pushed PR 194 to resolve this.

@acidprime
Copy link
Collaborator

closing please re-open if you can reproduce

@acidprime
Copy link
Collaborator

also closing as #194 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants