Replace the IPAddress gem with the built-in IPAddr class #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In hindsight, maybe it's better to leave the ipaddress parameters in the network class to not break compatibility. |
|
@bastelfreak there should be no more breaking changes now. The ipaddress gem is removed by default, in a future (major) release the code managing the gem can eventually be dropped. Remaining code warnings are fixed as well. |
bastelfreak
approved these changes
Dec 1, 2022
bastelfreak
added
enhancement
|
Thanks for the work! |
starlingx-github
pushed a commit
to starlingx/integ
that referenced
this pull request
Jun 19, 2023
During bootstrap, puppet throws a warning message that 'ipaddress gem was not found'. The puppet-network module uses the IPAddress gem to perform some validations. This gem can be replaced by the built-in class IPAddr and that way does not require the custom gem installation. This commit is sourced from a PR from the official repository of the puppet-network module: voxpupuli/puppet-network#290 Test Plan: PASS: Build & Install PASS: AIO-SX & AIO-DX Successful Bootstrap PASS: AIO-SX & AIO-DX Successful Unlock PASS: Check that 'ipaddress gem not found' warning is no longer present on puppet.log Story: 2010757 Task: 48425 Change-Id: I1158628165ea62dc642a6a392a036f1d68b4a2cf Signed-off-by: Luis Marquitti <luis.eduardoangelinimarquitti@windriver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The module relies on the IPAddress gem to perform certain validations.
It can be replaced by the IPAddr class, which does not require custom gem installation as it's part of the standard ruby distribution.
This pull request removes traces to the IPAddress gem in favour of the IPAddr class.
This Pull Request (PR) fixes the following issues
This should also fix #267