modulesync 4.2.0 & puppet-lint updates #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @bastelfreak, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
bastelfreak
changed the title
bastelfreak
force-pushed
the
modulesync
branch
2 times, most recently
from
64e989a to
b540f12
Compare
bastelfreak
changed the title
bastelfreak
force-pushed
the
modulesync
branch
from
b540f12 to
172b330
Compare
ekohl
reviewed
Aug 20, 2021
ekohl
reviewed
Aug 20, 2021
bastelfreak
force-pushed
the
modulesync
branch
3 times, most recently
from
3f17108 to
a9c93d4
Compare
bastelfreak
force-pushed
the
modulesync
branch
from
a9c93d4 to
61b10ea
Compare
smortex
approved these changes
Aug 20, 2021
Closed
alexjfisher
reviewed
Oct 28, 2021
| # Expected output: The ip address of the nexthop/default router | ||
| Facter.add('network_nexthop_ip') do | ||
| confine :kernel => :linux # rubocop:disable Style/HashSyntax | ||
| Facter.add(':network_nexthop_ip') do |
There was a problem hiding this comment.
@bastelfreak oops. This isn’t a symbol, but a string with a literal leading :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulesync 3.0.0