Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace explicit symlinks with an autogenerated ones #183

Merged
merged 1 commit into from
Sep 13, 2016
Merged

replace explicit symlinks with an autogenerated ones #183

merged 1 commit into from
Sep 13, 2016

Conversation

igalic
Copy link
Contributor

@igalic igalic commented Sep 13, 2016

previously we've had symlinks in spec/fixtures. Some operating systems
don't deal well with those, and as a consequence, our rspec suite has
been changed to verify whether a module contains symlinks. Even though
this module does not currently work on any platform that doesn't fully
support symlinks, we should be a good citizen and remove them.
.fixtures.yml has a mechanism to create them automatically, so we use
that now.

previously we've had symlinks in spec/fixtures. Some operating systems
don't deal well with those, and as a consequence, our rspec suite has
been changed to verify whether a module contains symlinks. Even though
this module does not currently work on any platform that doesn't fully
support symlinks, we should be a good citizen and remove them.
.fixtures.yml has a mechanism to create them automatically, so we use
that now.
@alexjfisher alexjfisher merged commit 78e30cf into voxpupuli:master Sep 13, 2016
@igalic igalic deleted the symlinks branch September 13, 2016 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants