Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rspec failures on RHEL6 #30

Closed
ericsakowski opened this issue Mar 20, 2013 · 2 comments
Closed

rspec failures on RHEL6 #30

ericsakowski opened this issue Mar 20, 2013 · 2 comments

Comments

@ericsakowski
Copy link
Contributor

[root@puppetski puppet-network]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 6.3 (Santiago)
[root@puppetski puppet-network]#
[root@puppetski puppet-network]# git pull
Already up-to-date.
[root@puppetski puppet-network]# git log -1
commit a137f37
Author: Adrien Thebo git@somethingsinistral.net
Date: Wed Mar 13 22:29:58 2013 -0700

Add puppet doc for network::bond

[root@puppetski puppet-network]# bundle exec rspec
.......................................................................................................................*._...............................FF_FFF*FFFFFFF.

Pending:
Puppet::Type::Network_config when validating the attribute options should be a descendant of the KeyValue property
# on conversion to specific type
# ./spec/unit/type/network_config_spec.rb:69
Puppet::Type::Network_config when validating the attribute value ipaddress should fail if a malformed address is used
# implementation of IP address validation
# ./spec/unit/type/network_config_spec.rb:104
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet family should fail when passed an IPv6 address
# implementation of IP address validation
# ./spec/unit/type/network_config_spec.rb:88
Puppet::Type::Network_config when validating the attribute value ipaddress using the inet6 family should fail when passed an IPv4 address
# implementation of IP address validation
# ./spec/unit/type/network_config_spec.rb:98
Puppet::Type::Network_config when validating the attribute value netmask should validate a CIDR netmask
# Not yet implemented
# ./spec/unit/type/network_config_spec.rb:111
Puppet::Type::Network_config when validating the attribute value netmask should fail if an invalid CIDR netmask is used
# implementation of IP address validation
# ./spec/unit/type/network_config_spec.rb:112
network::bond::debian with default bonding params should add a network_config resource for bond0
# rspec-puppet support for unordered hash matching
# ./spec/defines/bond/debian_spec.rb:32
network::bond::debian with non-default bonding params should add a network_config resource for bond0
# rspec-puppet support for unordered hash matching
# ./spec/defines/bond/debian_spec.rb:77

Failures:

  1. network::bond::debian with default bonding params should add a network_config resource for eth0
    Failure/Error: should contain_network_config(slave).with_ensure('absent')
    Puppet::Error:
    Unknown function join at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond/debian.pp:28 on node puppetski.service.datapipe.net

    ./spec/defines/bond/debian_spec.rb:28

  2. network::bond::debian with default bonding params should add a network_config resource for eth1
    Failure/Error: should contain_network_config(slave).with_ensure('absent')
    Puppet::Error:
    Unknown function join at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond/debian.pp:28 on node puppetski.service.datapipe.net

    ./spec/defines/bond/debian_spec.rb:28

  3. network::bond::debian with non-default bonding params should add a network_config resource for eth0
    Failure/Error: should contain_network_config(slave).with_ensure('absent')
    Puppet::Error:
    Unknown function join at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond/debian.pp:28 on node puppetski.service.datapipe.net

    ./spec/defines/bond/debian_spec.rb:73

  4. network::bond::debian with non-default bonding params should add a network_config resource for eth1
    Failure/Error: should contain_network_config(slave).with_ensure('absent')
    Puppet::Error:
    Unknown function join at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond/debian.pp:28 on node puppetski.service.datapipe.net

    ./spec/defines/bond/debian_spec.rb:73

  5. network::bond::debian with non-default bonding params should add a network_config resource for eth2
    Failure/Error: should contain_network_config(slave).with_ensure('absent')
    Puppet::Error:
    Unknown function join at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond/debian.pp:28 on node puppetski.service.datapipe.net

    ./spec/defines/bond/debian_spec.rb:73

  6. network::bond on platform RedHat should create 'network::bond::redhat'
    Failure/Error: should contain_network__bond__redhat('bond0')
    Puppet::Error:
    Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type kmod::alias at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond.pp:148 on node puppetski.service.datapipe.net

    ./spec/defines/bond_spec.rb:30

  7. network::bond on platform RedHat should forward all options to 'network::bond::redhat'
    Failure/Error: should contain_network__bond__redhat('bond0').with(params)
    Puppet::Error:
    Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type kmod::alias at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond.pp:148 on node puppetski.service.datapipe.net

    ./spec/defines/bond_spec.rb:34

  8. network::bond on platform Debian should create 'network::bond::debian'
    Failure/Error: should contain_network__bond__debian('bond0')
    Puppet::Error:
    Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type kmod::alias at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond.pp:148 on node puppetski.service.datapipe.net

    ./spec/defines/bond_spec.rb:42

  9. network::bond on platform Debian should forward all options to 'network::bond::debian'
    Failure/Error: should contain_network__bond__debian('bond0').with(params)
    Puppet::Error:
    Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type kmod::alias at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond.pp:148 on node puppetski.service.datapipe.net

    ./spec/defines/bond_spec.rb:46

  10. network::bond on platform on an unsupported osfamily should fail to compile
    Failure/Error: expect { subject }.to raise_error Puppet::Error, /network::bond does not support osfamily 'SparrowOS'/
    expected Puppet::Error with message matching /network::bond does not support osfamily 'SparrowOS'/, got #<Puppet::Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type kmod::alias at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond.pp:148 on node puppetski.service.datapipe.net>
    # ./spec/defines/bond_spec.rb:54

  11. network::bond configuring the kernel bonding device
    Failure/Error: it { should include_class('network::bond::setup') }
    Puppet::Error:
    Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type kmod::alias at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond.pp:148 on node puppetski.service.datapipe.net
    # ./spec/defines/bond_spec.rb:62

  12. network::bond configuring the kernel bonding device should add a kernel module alias for the bonded device
    Failure/Error: })
    Puppet::Error:
    Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type kmod::alias at /tmp/puppet-network/spec/fixtures/modules/network/manifests/bond.pp:148 on node puppetski.service.datapipe.net
    # ./spec/defines/bond_spec.rb:68

Finished in 3.13 seconds
172 examples, 12 failures, 8 pending

Failed examples:

rspec ./spec/defines/bond/debian_spec.rb:27 # network::bond::debian with default bonding params should add a network_config resource for eth0
rspec ./spec/defines/bond/debian_spec.rb:27 # network::bond::debian with default bonding params should add a network_config resource for eth1
rspec ./spec/defines/bond/debian_spec.rb:72 # network::bond::debian with non-default bonding params should add a network_config resource for eth0
rspec ./spec/defines/bond/debian_spec.rb:72 # network::bond::debian with non-default bonding params should add a network_config resource for eth1
rspec ./spec/defines/bond/debian_spec.rb:72 # network::bond::debian with non-default bonding params should add a network_config resource for eth2
rspec ./spec/defines/bond_spec.rb:29 # network::bond on platform RedHat should create 'network::bond::redhat'
rspec ./spec/defines/bond_spec.rb:33 # network::bond on platform RedHat should forward all options to 'network::bond::redhat'
rspec ./spec/defines/bond_spec.rb:41 # network::bond on platform Debian should create 'network::bond::debian'
rspec ./spec/defines/bond_spec.rb:45 # network::bond on platform Debian should forward all options to 'network::bond::debian'
rspec ./spec/defines/bond_spec.rb:53 # network::bond on platform on an unsupported osfamily should fail to compile
rspec ./spec/defines/bond_spec.rb:62 # network::bond configuring the kernel bonding device
rspec ./spec/defines/bond_spec.rb:64 # network::bond configuring the kernel bonding device should add a kernel module alias for the bonded device
[root@puppetski puppet-network]#
@adrienthebo
Copy link
Member

@ericsakowski I've been really swamped for the last while, is this still a problem for you? If you run bundle exec rake fixture:prepare and then run rspec, do the tests pass?

@ericsakowski
Copy link
Contributor Author

@adrienthebo 218 examples, 0 failures, 6 pending
I guess it got fixed along the way. Thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrienthebo @ericsakowski