Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change netmask to cidr for redhat/centos #209

Closed
dn1s opened this issue Dec 29, 2016 · 4 comments · Fixed by #282
Closed

Change netmask to cidr for redhat/centos #209

dn1s opened this issue Dec 29, 2016 · 4 comments · Fixed by #282
Labels
bug Something isn't working

Comments

@dn1s
Copy link

dn1s commented Dec 29, 2016

https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Deployment_Guide/sec-Configuring_Static_Routes_in_ifcfg_files.html

As you can see redhat/centos no longer uses ipaddress/netmask for route creation therefore route files can be created but won't be applied. Fix is to remove netmask from redhat route ruby code and replace it with cidr instead.

i have a quick example how to archive this with no ruby code at all but as well without checking here:
https://github.com/dn1s/puppet_network

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Jan 1, 2017
@olifre
Copy link
Contributor

olifre commented Feb 14, 2018

Any news on this?
It seems that as of now, there is no RedHat / CentOS based OS supported by this module anymore which has a working network_route resource, so maybe it should just fail hard instead of create a broken route.

It took me a while to figure this issue out, especially since the route-file parser parses 255.255.255.0 as CIDR 25 and creates a corresponding rule.
Failure would certainly be better than misconfiguration.

@dhollinger
Copy link
Member

@olifre I will try and take a look at this tonight.

@dhollinger dhollinger added enhancement New feature or request and removed bug Something isn't working labels Mar 13, 2018
@dhollinger
Copy link
Member

@olifre The netmask parameter already supports CIDR format as of now. I will work on trying to enforce that in the future, once I have some bandwidth available to do so. This refactor to enforce CIDR format for netmask in EL7 will probably be done as part of the refactor to have puppet-network use the ip route command to add routes instead of just placing a file that will then require a notify to a service or exec to load.

@oniGino
Copy link

oniGino commented May 6, 2022

same problem as #281
Pretty sure this module is totally abandoned its been over a year with no dev work

@bastelfreak bastelfreak added bug Something isn't working and removed enhancement New feature or request labels May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants