feat: implement initial root API token management#470
Draft
jay7x wants to merge 5 commits intovoxpupuli:masterfrom
Draft
feat: implement initial root API token management#470jay7x wants to merge 5 commits intovoxpupuli:masterfrom
jay7x wants to merge 5 commits intovoxpupuli:masterfrom
Conversation
yakatz
requested changes
Aug 3, 2025
Member
There was a problem hiding this comment.
I don't mind the "hack-ish" approach, but some other thoughts:
- The documentation should have a warning about how this could be insecure.
- A change like this needs an acceptance test to make sure the script actually works.
- I would also like to see a test that it doesn't run the script twice - it shouldn't the way it is written now, but it would be good to have for the future.
TheMeier
reviewed
Aug 3, 2025
| Integer[0] $token_ttl_minutes, | ||
| Stdlib::AbsolutePath $token_file_path, | ||
| |-%> | ||
| # This scripts creates an initial root token and stores it to the |
Member
There was a problem hiding this comment.
It's executed through the Gitlab Rails Runner, so it shouldn't need one.
Member
Author
There was a problem hiding this comment.
I'll add comment there to reduce confusion :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements somehow hack-ish, but the only possible way to create an initial root API token during the Gitlab installation. This allows to start managing Gitlab resources via API immediately after it is installed.
While I understand how bad it looks, I guess the benefits are big enough..