Skip to content

Execute pre_commit_script as a complete path #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekohl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Execute pre_commit_script as a complete path #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions contrib/openstack-commit-msg-hook.sh
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions lib/modulesync/repository.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,8 @@
opts_push = {}
opts_commit = { amend: true } if options[:amend]
opts_push = { force: true } if options[:force]
if options[:pre_commit_script]

Check failure on line 147 in lib/modulesync/repository.rb

View workflow job for this annotation

GitHub Actions / rubocop_and_matrix 

Style/IfUnlessModifier: Favor modifier `if` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`. (https://rubystyle.guide#if-as-a-modifier)
script = "#{File.dirname(File.dirname(__FILE__))}/../contrib/#{options[:pre_commit_script]}"
`#{script} #{@directory}`
system(options[:pre_commit_script], @directory)
end
repo.commit(message, opts_commit)
if options[:remote_branch]
Expand Down
Loading