Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export strict assertion mode functions #406

Open
strugee opened this issue Jun 19, 2020 · 0 comments
Open

Export strict assertion mode functions #406

strugee opened this issue Jun 19, 2020 · 0 comments
Milestone

Comments

@strugee
Copy link
Member

strugee commented Jun 19, 2020

Apparently Node core now has a strict assertion mode, and the old behavior ("legacy assertion mode") is deprecated. See https://nodejs.org/api/assert.html#assert_strict_assertion_mode.

I think we should probably make require('vows').assert export strict mode functions, since the legacy mode functions a) are deprecated and b) cause surprising results since they use ==. Assuming we do this, we should do it before 1.0.0 final because it's a breaking change.

@strugee strugee added this to the v1.0 milestone Jun 19, 2020
@strugee strugee changed the title Export strict assertion mode funcitons Export strict assertion mode functions Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant