Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 1, 2025

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested review from AdamGS and joseph-isaacs and removed request for AdamGS December 1, 2025 21:52
@gatesn gatesn added the feature Release label indicating a new feature or request label Dec 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #5603 will degrade performances by 12.46%

Comparing ngates/allow-non-null-mask-child (3bbfa4b) with develop (168982b)

Summary

❌ 2 regressions
✅ 1156 untouched
⏩ 617 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
bench_many_nulls[0.5] 322.7 µs 359.2 µs -10.15%
bench_many_nulls[0.9] 461.6 µs 527.3 µs -12.46%

Footnotes

  1. 617 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.62%. Comparing base (168982b) to head (3bbfa4b).

Files with missing lines Patch % Lines
vortex-array/src/arrays/masked/vtable/mod.rs 91.66% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

})
}

pub fn child(&self) -> &ArrayRef {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename this to way it doesn't include the mask?

/// If false, then the child array's DType is the masked array's DType.as_nonnullable() as was
/// the legacy behavior of this array.
#[prost(bool, tag = "1")]
pub(super) passthrough_child_dtype: bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why this makes more sense for the build, but I would think that you want child nullability?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants