-
Notifications
You must be signed in to change notification settings - Fork 98
Allow nullable children of MaskedArray #5603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
CodSpeed Performance ReportMerging #5603 will degrade performances by 12.46%Comparing Summary
Benchmarks breakdown
Footnotes
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }) | ||
| } | ||
|
|
||
| pub fn child(&self) -> &ArrayRef { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename this to way it doesn't include the mask?
| /// If false, then the child array's DType is the masked array's DType.as_nonnullable() as was | ||
| /// the legacy behavior of this array. | ||
| #[prost(bool, tag = "1")] | ||
| pub(super) passthrough_child_dtype: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see why this makes more sense for the build, but I would think that you want child nullability?
No description provided.