Skip to content

Conversation

@a10y
Copy link
Contributor

@a10y a10y commented Nov 25, 2025

Fix potential out of bounds panic in the scalar Take kernel for PrimitiveArray.

We could definitely do this faster, e.g. by unrolling the loop 8x and dispatching based on the validity of the next 8 indices, but most production platforms will take the AVX2 kernel or the nightly Portable SIMD kernel anyway.

@a10y a10y requested a review from connortsui20 November 25, 2025 19:08
@a10y a10y added the fix label Nov 25, 2025
@a10y a10y force-pushed the aduffy/fix-prim-scalar-take branch 2 times, most recently from c16019a to 0d1f25a Compare November 25, 2025 19:11
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y force-pushed the aduffy/fix-prim-scalar-take branch from 0d1f25a to b3eec28 Compare November 25, 2025 19:11
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y added 2 commits November 25, 2025 21:30
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y enabled auto-merge (squash) November 26, 2025 02:42
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #5535 will not alter performance

Comparing aduffy/fix-prim-scalar-take (7101064) with develop (a63d0ab)

Summary

✅ 181 untouched
⏩ 1532 skipped1

Footnotes

  1. 1532 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants