Skip to content

Conversation

@joseph-isaacs
Copy link
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #5441 will degrade performances by 20.47%

Comparing ji/node-trav-for-arr (3c12e26) with develop (aafe376)

Summary

⚡ 8 improvements
❌ 6 regressions
✅ 1501 untouched
🆕 7 new
⏩ 7 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 decompress[("alp_for_bp_f64", 0x45bf8e0)] N/A 30.3 ms N/A
🆕 decompress[("datetime_for_bp", 0x45c23b0)] N/A 41.7 ms N/A
🆕 decompress[("dict_fsst_varbin_bp_string", 0x45c1830)] N/A 76.3 ms N/A
🆕 decompress[("dict_fsst_varbin_string", 0x45c14b0)] N/A 76.3 ms N/A
🆕 decompress[("dict_varbinview_string", 0x45c0300)] N/A 75.6 ms N/A
🆕 decompress[("for_bp_u64", 0x45bf190)] N/A 2.5 ms N/A
🆕 decompress[("runend_for_bp_u32", 0x45c0690)] N/A 2.1 ms N/A
in_place_batch[100352] 406.8 µs 318.3 µs +27.81%
in_place_batch[86016] 273 µs 326.9 µs -16.5%
in_place_pipeline[1024] 4 µs 5 µs -20.47%
in_place_pipeline[262144] 398.2 µs 331.1 µs +20.28%
in_place_pipeline[65536] 101.1 µs 85.3 µs +18.52%
pipeline[16384] 27.7 µs 32 µs -13.4%
pipeline[262144] 402.3 µs 335.2 µs +20.04%
pipeline[8192] 16.6 µs 19.7 µs -15.73%
pipeline_extra_copy[100352] 132.8 µs 158.6 µs -16.28%
pipeline_extra_copy[1024] 7.9 µs 8.9 µs -10.87%
pipeline_extra_copy[16384] 31.9 µs 27.9 µs +14.55%
pipeline_extra_copy[65536] 106.1 µs 89.3 µs +18.74%
verify_all_methods[1024] 391.5 µs 319.7 µs +22.46%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 94.75983% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.08%. Comparing base (fd5a013) to head (3c12e26).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/array/visitor.rs 96.65% 15 Missing ⚠️
vortex-array/src/array/traversal.rs 90.00% 6 Missing ⚠️
vortex-array/src/array/mod.rs 50.00% 4 Missing ⚠️
vortex-array/src/expr/traversal/mod.rs 96.58% 4 Missing ⚠️
vortex-array/src/pipeline/driver/mod.rs 33.33% 2 Missing ⚠️
encodings/bytebool/src/array.rs 0.00% 1 Missing ⚠️
encodings/fastlanes/src/delta/mod.rs 0.00% 1 Missing ⚠️
vortex-array/src/arrays/null/mod.rs 0.00% 1 Missing ⚠️
vortex-array/src/arrow/array.rs 0.00% 1 Missing ⚠️
vortex-array/src/expr/traversal/visitor.rs 75.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

1 similar comment
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 94.75983% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.08%. Comparing base (fd5a013) to head (3c12e26).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/array/visitor.rs 96.65% 15 Missing ⚠️
vortex-array/src/array/traversal.rs 90.00% 6 Missing ⚠️
vortex-array/src/array/mod.rs 50.00% 4 Missing ⚠️
vortex-array/src/expr/traversal/mod.rs 96.58% 4 Missing ⚠️
vortex-array/src/pipeline/driver/mod.rs 33.33% 2 Missing ⚠️
encodings/bytebool/src/array.rs 0.00% 1 Missing ⚠️
encodings/fastlanes/src/delta/mod.rs 0.00% 1 Missing ⚠️
vortex-array/src/arrays/null/mod.rs 0.00% 1 Missing ⚠️
vortex-array/src/arrow/array.rs 0.00% 1 Missing ⚠️
vortex-array/src/expr/traversal/visitor.rs 75.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants