refactor(bench): use composable argument groups to prevent unused args #5425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all benchmarks accepted a single CommonArgs struct via flatten, which meant benchmarks would silently accept arguments they didn't use (e.g., fineweb accepting --scale-factor, statpopgen accepting --use-remote-data-dir).
This refactor splits CommonArgs into focused, semantically-related groups:
Benchmarks now explicitly flatten only the groups they support:
Benefits:
🤖 Generated with Claude Code