Lazy display_tree

[blaginin]

Quite often I do have a vortex array which I know evaluates to an error, but I can't debug-print it's tree because this will cause it's execution (which is failing).

Example:

thread 'scan::tests::filter::test_key_filter' (17400903) panicked at /Users/blaginin/Documents/vortex/vortex-error/src/lib.rs:324:13:
AllTrue and AllFalse are handled by filter fn
Backtrace:
   0: std::backtrace_rs::backtrace::libunwind::trace
             at /rustc/c23ed3ef28b3cc30658310f771ddc66e5b687cf4/library/std/src/../../backtrace/src/backtrace/libunwind.rs:117:9
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/c23ed3ef28b3cc30658310f771ddc66e5b687cf4/library/std/src/../../backtrace/src/backtrace/mod.rs:66:14
   2: std::backtrace::Backtrace::create
             at /rustc/c23ed3ef28b3cc30658310f771ddc66e5b687cf4/library/std/src/backtrace.rs:331:13
   3: <core::option::Option<&vortex_mask::MaskValues> as vortex_error::VortexExpect>::vortex_expect::{closure#0}
             at /Users/blaginin/Documents/vortex/vortex-error/src/lib.rs:322:26
   4: <core::option::Option<&vortex_mask::MaskValues>>::unwrap_or_else::<<core::option::Option<&vortex_mask::MaskValues> as vortex_error::VortexExpect>::vortex_expect::{closure#0}>
             at /Users/blaginin/.rustup/toolchains/nightly-2025-11-24-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/option.rs:1067:21
   5: <core::option::Option<&vortex_mask::MaskValues> as vortex_error::VortexExpect>::vortex_expect
             at /Users/blaginin/Documents/vortex/vortex-error/src/lib.rs:319:14
   6: vortex_array::arrays::varbin::compute::filter::filter_select_var_bin
             at /Users/blaginin/Documents/vortex/vortex-array/src/arrays/varbin/compute/filter.rs:40:10
   7: <vortex_array::arrays::varbin::vtable::VarBinVTable as vortex_array::compute::filter::FilterKernel>::filter
             at /Users/blaginin/Documents/vortex/vortex-array/src/arrays/varbin/compute/filter.rs:31:9
   8: <vortex_fsst::kernel::FSSTFilterKernel as vortex_array::kernel::ExecuteParentKernel<vortex_fsst::array::FSSTVTable>>::execute_parent
             at /Users/blaginin/Documents/vortex/encodings/fsst/src/kernel.rs:42:13
   9: <vortex_array::kernel::ParentKernelAdapter<vortex_fsst::array::FSSTVTable, vortex_fsst::kernel::FSSTFilterKernel> as vortex_array::kernel::DynParentKernel<vortex_fsst::array::FSSTVTable>>::execute_parent
             at /Users/blaginin/Documents/vortex/vortex-array/src/kernel.rs:119:14
  10: <vortex_array::kernel::ParentKernelSet<vortex_fsst::array::FSSTVTable>>::execute
             at /Users/blaginin/Documents/vortex/vortex-array/src/kernel.rs:53:43
  11: <vortex_fsst::array::FSSTVTable as vortex_array::vtable::VTable>::execute_parent
             at /Users/blaginin/Documents/vortex/encodings/fsst/src/array.rs:207:24
  12: <vortex_array::vtable::dyn_::ArrayVTableAdapter<vortex_fsst::array::FSSTVTable> as vortex_array::vtable::dyn_::DynVTable>::execute_parent
             at /Users/blaginin/Documents/vortex/vortex-array/src/vtable/dyn_.rs:181:28
  13: <vortex_array::canonical::Canonical as vortex_array::executor::Executable>::execute
             at /Users/blaginin/Documents/vortex/vortex-array/src/executor.rs:91:22
  14: <dyn vortex_array::array::Array>::execute::<vortex_array::canonical::Canonical>
             at /Users/blaginin/Documents/vortex/vortex-array/src/executor.rs:46:9
  15: <vortex_array::expr::vtable::ExecutionResult as vortex_array::executor::Executable>::execute
             at /Users/blaginin/Documents/vortex/vortex-array/src/expr/vtable.rs:347:50
  16: <dyn vortex_array::array::Array>::execute::<vortex_array::expr::vtable::ExecutionResult>
             at /Users/blaginin/Documents/vortex/vortex-array/src/executor.rs:46:9
   ...
  52: vortex_array::arrays::scalar_fn::vtable::validity::execute_expr
             at /Users/blaginin/Documents/vortex/vortex-array/src/arrays/scalar_fn/vtable/validity.rs:47:10
  53: <vortex_array::arrays::scalar_fn::vtable::ScalarFnVTable as vortex_array::vtable::validity::ValidityVTable<vortex_array::arrays::scalar_fn::vtable::ScalarFnVTable>>::validity
             at /Users/blaginin/Documents/vortex/vortex-array/src/arrays/scalar_fn/vtable/validity.rs:75:28
  54: <vortex_array::array::ArrayAdapter<vortex_array::arrays::scalar_fn::vtable::ScalarFnVTable> as vortex_array::array::Array>::validity
             at /Users/blaginin/Documents/vortex/vortex-array/src/array/mod.rs:612:28
  55: <vortex_array::array::ArrayAdapter<vortex_array::arrays::scalar_fn::vtable::ScalarFnVTable> as vortex_array::array::Array>::all_valid
             at /Users/blaginin/Documents/vortex/vortex-array/src/array/mod.rs:566:20
  56: <vortex_array::display::tree::StatsDisplay as core::fmt::Display>::fmt
             at /Users/blaginin/Documents/vortex/vortex-array/src/display/tree.rs:46:26

I want to have something like array.display_lazy_tree which will never evaluate. Or maybe we should change the exiting display_tree?

[blaginin]

fyi @AdamGS

[robert3005]

This bug got introduced yesterday. Filter shouldn’t be called directly like this

[blaginin]

for sure! i created a bug report here: #6271

This issue is about having a way to debug-print a failing array (because we spend quite a lot of time trying to recreate the bug often i feel)

[robert3005]

Ah this comes from checking all_valid in display_tree. I think we just have to forbid methods that can cause execution. I think this would be clearer if we made those take execution context and then you don't have it in the dislpay implementation