Add issue to explain why we don't support DF dynamic expressions

AdamGS · AdamGS · commit eb469f8e8ce9 · 2025-09-16T16:42:54.000+01:00
Signed-off-by: Adam Gutglick &lt;adam@spiraldb.com&gt;
diff --git a/vortex-datafusion/src/convert/exprs.rs b/vortex-datafusion/src/convert/exprs.rs
@@ -123,7 +123,8 @@ impl TryFromDataFusion<DFOperator> for Operator {
 }
 
 pub(crate) fn can_be_pushed_down(expr: &PhysicalExprRef, schema: &Schema) -> bool {
-    // We currently do not support pushdown of dynamic expressions in DF
+    // We currently do not support pushdown of dynamic expressions in DF.
+    // See issue: https://github.com/vortex-data/vortex/issues/4034
     if is_dynamic_physical_expr(expr) {
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,8 @@ impl TryFromDataFusion<DFOperator> for Operator {`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`pub(crate) fn can_be_pushed_down(expr: &PhysicalExprRef, schema: &Schema) -> bool {`
`126`		`- // We currently do not support pushdown of dynamic expressions in DF`
	`126`	`+ // We currently do not support pushdown of dynamic expressions in DF.`
	`127`	`+ // See issue: https://github.com/vortex-data/vortex/issues/4034`
`127`	`128`	`if is_dynamic_physical_expr(expr) {`
`128`	`129`	`return false;`
`129`	`130`	`}`