chore[*]: prefer #[expect(..)] over #[allow(..)] (#5498)

joseph-isaacs · a10y · commit 81a7e19d8b4f · 2025-11-25T14:32:59.000-05:00
We cannot fully remove allow

---------

Signed-off-by: Joe Isaacs &lt;joe.isaacs@live.co.uk&gt;
diff --git a/encodings/alp/src/alp/compress.rs b/encodings/alp/src/alp/compress.rs
@@ -161,7 +161,10 @@ pub fn decompress(array: ALPArray) -> PrimitiveArray {
 /// # Returns
 ///
 /// A `PrimitiveArray` containing the decompressed values with all patches applied.
-#[allow(clippy::cognitive_complexity)]
+#[expect(
+    clippy::cognitive_complexity,
+    reason = "complexity is from nested match_each_* macros"
+)]
 pub fn decompress_chunked(
     array: ALPArray,
     patches: &Patches,
diff --git a/encodings/alp/src/alp/mod.rs b/encodings/alp/src/alp/mod.rs
@@ -154,7 +154,10 @@ pub trait ALPFloat: private::Sealed + Float + Display + NativePType {
         encoded_bytes + patch_bytes
     }
 
-    #[allow(clippy::type_complexity)]
+    #[expect(
+        clippy::type_complexity,
+        reason = "tuple return type is appropriate for multiple encoding outputs"
+    )]
     fn encode(
         values: &[Self],
         exponents: Option<Exponents>,
diff --git a/encodings/fastlanes/src/rle/array/mod.rs b/encodings/fastlanes/src/rle/array/mod.rs
@@ -127,7 +127,6 @@ impl RLEArray {
     /// - The `indices` array contains valid indices into chunks of the `values` array
     /// - The `values_idx_offsets` array contains valid chunk start offsets
     /// - The `validity` array has the same length as `length`
-    #[allow(clippy::too_many_arguments)]
     pub unsafe fn new_unchecked(
         values: ArrayRef,
         indices: ArrayRef,
@@ -182,7 +181,10 @@ impl RLEArray {
     /// Offsets in `values_idx_offsets` are absolute and need to be shifted
     /// by the offset of the first chunk, respective the current slice, in
     /// order to make them relative.
-    #[allow(clippy::expect_used)]
+    #[expect(
+        clippy::expect_used,
+        reason = "expect is safe here as scalar_at returns a valid primitive"
+    )]
     pub(crate) fn values_idx_offset(&self, chunk_idx: usize) -> usize {
         self.values_idx_offsets
             .scalar_at(chunk_idx)
diff --git a/encodings/fastlanes/src/rle/array/rle_decompress.rs b/encodings/fastlanes/src/rle/array/rle_decompress.rs
@@ -19,7 +19,10 @@ use crate::FL_CHUNK_SIZE;
 use crate::RLEArray;
 
 /// Decompresses an RLE array back into a primitive array.
-#[allow(clippy::cognitive_complexity)]
+#[expect(
+    clippy::cognitive_complexity,
+    reason = "complexity is from nested match_each_* macros"
+)]
 pub fn rle_decompress(array: &RLEArray) -> PrimitiveArray {
     match_each_native_ptype!(array.values().dtype().as_ptype(), |V| {
         match_each_unsigned_integer_ptype!(array.values_idx_offsets().dtype().as_ptype(), |O| {
@@ -37,7 +40,6 @@ pub fn rle_decompress(array: &RLEArray) -> PrimitiveArray {
 }
 
 /// Decompresses an `RLEArray` into to a primitive array of unsigned integers.
-#[allow(clippy::cognitive_complexity)]
 fn rle_decode_typed<V, I, O>(array: &RLEArray) -> PrimitiveArray
 where
     V: NativePType + RLE + Clone + Copy,
diff --git a/encodings/fsst/src/canonical.rs b/encodings/fsst/src/canonical.rs
@@ -50,7 +50,10 @@ impl CanonicalVTable<FSSTVTable> for FSSTVTable {
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(
+    clippy::cast_possible_truncation,
+    reason = "truncation is intentional for buffer index"
+)]
 fn fsst_decode_views(fsst_array: &FSSTArray, buf_index: u32) -> (ByteBuffer, Buffer<BinaryView>) {
     // FSSTArray has two child arrays:
     //  1. A VarBinArray, which holds the string heap of the compressed codes.
diff --git a/encodings/sparse/src/canonical.rs b/encodings/sparse/src/canonical.rs
@@ -115,7 +115,10 @@ impl CanonicalVTable<SparseVTable> for SparseVTable {
     }
 }
 
-#[allow(clippy::cognitive_complexity)]
+#[expect(
+    clippy::cognitive_complexity,
+    reason = "complexity is from nested match_smallest_offset_type macro"
+)]
 fn canonicalize_sparse_lists(
     array: &SparseArray,
     values_dtype: Arc<DType>,
diff --git a/vortex-array/src/arrays/primitive/array/conversion.rs b/vortex-array/src/arrays/primitive/array/conversion.rs
@@ -110,7 +110,6 @@ impl PrimitiveArray {
     }
 
     /// Try to extract a mutable buffer from the PrimitiveArray with zero copy.
-    #[allow(clippy::panic_in_result_fn)]
     pub fn try_into_buffer_mut<T: NativePType>(self) -> Result<BufferMut<T>, PrimitiveArray> {
         if T::PTYPE != self.ptype() {
             vortex_panic!(
diff --git a/vortex-array/src/arrays/primitive/array/patch.rs b/vortex-array/src/arrays/primitive/array/patch.rs
@@ -14,7 +14,6 @@ use crate::validity::Validity;
 use crate::vtable::ValidityHelper;
 
 impl PrimitiveArray {
-    #[allow(clippy::cognitive_complexity)]
     pub fn patch(self, patches: &Patches) -> Self {
         let patch_indices = patches.indices().to_primitive();
         let patch_values = patches.values().to_primitive();
@@ -72,7 +71,10 @@ impl PrimitiveArray {
 /// * `base_offset` - Base offset from the first chunk
 /// * `offset_within_chunk` - Offset within chunk for sliced patches
 #[inline]
-#[allow(clippy::too_many_arguments)]
+#[expect(
+    clippy::too_many_arguments,
+    reason = "all arguments are needed for the patching operation"
+)]
 pub fn patch_chunk<T, I, C>(
     decoded_values: &mut [T],
     patches_indices: &[I],
diff --git a/vortex-array/src/arrays/struct_/array.rs b/vortex-array/src/arrays/struct_/array.rs
@@ -381,7 +381,6 @@ impl StructArray {
     /// which specifies the new ordering of columns in the struct. The projection can be used to
     /// perform column re-ordering, deletion, or duplication at a logical level, without any data
     /// copying.
-    #[allow(clippy::same_name_method)]
     pub fn project(&self, projection: &[FieldName]) -> VortexResult<Self> {
         let mut children = Vec::with_capacity(projection.len());
         let mut names = Vec::with_capacity(projection.len());
diff --git a/vortex-array/src/arrays/varbin/array.rs b/vortex-array/src/arrays/varbin/array.rs
@@ -243,7 +243,10 @@ impl VarBinArray {
         builder.finish(dtype)
     }
 
-    #[allow(clippy::same_name_method)]
+    #[expect(
+        clippy::same_name_method,
+        reason = "intentionally named from_iter like Iterator::from_iter"
+    )]
     pub fn from_iter<T: AsRef<[u8]>, I: IntoIterator<Item = Option<T>>>(
         iter: I,
         dtype: DType,
diff --git a/vortex-array/src/arrays/varbinview/array.rs b/vortex-array/src/arrays/varbinview/array.rs
@@ -322,7 +322,10 @@ impl VarBinViewArray {
     }
 
     /// Accumulate an iterable set of values into our type here.
-    #[allow(clippy::same_name_method)]
+    #[expect(
+        clippy::same_name_method,
+        reason = "intentionally named from_iter like Iterator::from_iter"
+    )]
     pub fn from_iter<T: AsRef<[u8]>, I: IntoIterator<Item = Option<T>>>(
         iter: I,
         dtype: DType,
diff --git a/vortex-array/src/compute/is_sorted.rs b/vortex-array/src/compute/is_sorted.rs
@@ -213,7 +213,10 @@ pub trait IsSortedKernel: VTable {
     fn is_strict_sorted(&self, array: &Self::Array) -> VortexResult<Option<bool>>;
 }
 
-#[allow(clippy::wrong_self_convention)]
+#[expect(
+    clippy::wrong_self_convention,
+    reason = "is_* naming follows Iterator::is_sorted convention"
+)]
 /// Helper methods to check sortedness with strictness
 pub trait IsSortedIteratorExt: Iterator
 where
diff --git a/vortex-array/src/compute/mod.rs b/vortex-array/src/compute/mod.rs
@@ -380,7 +380,10 @@ pub enum Output {
     Array(ArrayRef),
 }
 
-#[allow(clippy::len_without_is_empty)]
+#[expect(
+    clippy::len_without_is_empty,
+    reason = "Output is always non-empty (scalar has len 1)"
+)]
 impl Output {
     pub fn dtype(&self) -> &DType {
         match self {
diff --git a/vortex-array/src/patches.rs b/vortex-array/src/patches.rs
@@ -704,7 +704,10 @@ impl Patches {
         }
     }
 
-    #[allow(clippy::cognitive_complexity)]
+    #[expect(
+        clippy::cognitive_complexity,
+        reason = "complexity is from nested match_each_* macros"
+    )]
     pub fn take_search(
         &self,
         take_indices: PrimitiveArray,
diff --git a/vortex-buffer/src/string.rs b/vortex-buffer/src/string.rs
@@ -71,7 +71,10 @@ impl TryFrom<ByteBuffer> for BufferString {
 
     fn try_from(value: ByteBuffer) -> Result<Self, Self::Error> {
         simdutf8::basic::from_utf8(value.as_ref()).map_err(|_| {
-            #[allow(clippy::unwrap_used)]
+            #[expect(
+                clippy::unwrap_used,
+                reason = "unwrap is intentional - the error was already detected"
+            )]
             // run validation using `compat` package to get more detailed error message
             let err = simdutf8::compat::from_utf8(value.as_ref()).unwrap_err();
             vortex_err!("invalid utf-8: {err}")
diff --git a/vortex-datafusion/src/persistent/format.rs b/vortex-datafusion/src/persistent/format.rs
@@ -107,7 +107,10 @@ impl GetExt for VortexFormatFactory {
 
 impl VortexFormatFactory {
     /// Creates a new instance with a default [`VortexSession`] and default options.
-    #[allow(clippy::new_without_default)] // FormatFactory defines `default` method, so having `Default` implementation is confusing.
+    #[expect(
+        clippy::new_without_default,
+        reason = "FormatFactory defines `default` method, so having `Default` implementation is confusing"
+    )]
     pub fn new() -> Self {
         Self {
             session: VortexSession::default(),
@@ -140,7 +143,7 @@ impl VortexFormatFactory {
 }
 
 impl FileFormatFactory for VortexFormatFactory {
-    #[allow(clippy::disallowed_types)]
+    #[expect(clippy::disallowed_types, reason = "required by trait signature")]
     fn create(
         &self,
         _state: &dyn Session,
diff --git a/vortex-dtype/src/arbitrary/decimal.rs b/vortex-dtype/src/arbitrary/decimal.rs
@@ -97,7 +97,6 @@ impl Int for U256Wrapper {
     }
 }
 
-#[allow(clippy::same_name_method)]
 impl Int for i256 {
     type Unsigned = U256Wrapper;
     const ZERO: Self = i256::ZERO;
diff --git a/vortex-dtype/src/arbitrary/mod.rs b/vortex-dtype/src/arbitrary/mod.rs
@@ -94,11 +94,6 @@ impl<'a> Arbitrary<'a> for PType {
 }
 
 impl<'a> Arbitrary<'a> for DecimalDType {
-    #[allow(
-        clippy::unwrap_in_result,
-        clippy::expect_used,
-        clippy::cast_possible_truncation
-    )]
     fn arbitrary(u: &mut Unstructured<'a>) -> Result<Self> {
         // Get a random integer for the scale
         let precision = u.int_in_range(1..=i256::MAX_PRECISION)?;
diff --git a/vortex-dtype/src/bigint/mod.rs b/vortex-dtype/src/bigint/mod.rs
@@ -32,11 +32,17 @@ use vortex_error::VortexExpect;
 /// This is one of the physical representations of `DecimalScalar` values and can be safely converted
 /// back and forth with Arrow's [`i256`][arrow_buffer::i256].
 #[repr(transparent)]
-#[allow(non_camel_case_types)]
+#[expect(
+    non_camel_case_types,
+    reason = "i256 matches Rust primitive naming convention"
+)]
 #[derive(Debug, Copy, Clone, Default, Eq, PartialEq, Hash, PartialOrd, Ord)]
 pub struct i256(arrow_buffer::i256);
 
-#[allow(clippy::same_name_method)]
+#[expect(
+    clippy::same_name_method,
+    reason = "inherent methods intentionally shadow arrow_buffer::i256 methods"
+)]
 impl i256 {
     /// The zero value for `i256`.
     pub const ZERO: Self = Self(arrow_buffer::i256::ZERO);
diff --git a/vortex-dtype/src/ptype.rs b/vortex-dtype/src/ptype.rs
@@ -179,7 +179,7 @@ mod private {
 }
 
 /// A visitor trait for converting a `NativePType` to another parameterized type.
-#[allow(missing_docs)] // Kind of obvious.
+#[expect(missing_docs, reason = "method names are self-documenting")]
 pub trait PTypeDowncast {
     type Output<T: NativePType>;
 
@@ -224,7 +224,7 @@ macro_rules! impl_ptype_downcast {
 }
 
 /// A visitor trait for converting a generic `NativePType` into a non-parameterized type.
-#[allow(missing_docs)] // Kind of obvious.
+#[expect(missing_docs, reason = "method names are self-documenting")]
 pub trait PTypeUpcast {
     type Input<T: NativePType>;
 
diff --git a/vortex-duckdb/src/convert/expr.rs b/vortex-duckdb/src/convert/expr.rs
@@ -43,7 +43,10 @@ fn like_pattern_str(value: &duckdb::Expression) -> VortexResult<Option<String>>
     }
 }
 
-#[allow(clippy::cognitive_complexity)]
+#[expect(
+    clippy::cognitive_complexity,
+    reason = "complexity from exhaustive match on expression types"
+)]
 pub fn try_from_bound_expression(value: &duckdb::Expression) -> VortexResult<Option<Expression>> {
     let Some(value) = value.as_class() else {
         log::debug!("no expression class id {:?}", value.as_class_id());
diff --git a/vortex-duckdb/src/duckdb/vector.rs b/vortex-duckdb/src/duckdb/vector.rs
@@ -176,7 +176,6 @@ impl Vector {
         unsafe { LogicalType::own(cpp::duckdb_vector_get_column_type(self.as_ptr())) }
     }
 
-    #[allow(clippy::expect_used)]
     /// Ensure the validity slice is writable.
     ///
     /// # SAFETY
@@ -186,7 +185,10 @@ impl Vector {
         unsafe { self.ensure_validity_slice(capacity) }.view_bits_mut()
     }
 
-    #[allow(clippy::expect_used)]
+    #[expect(
+        clippy::expect_used,
+        reason = "expect is safe after ensure_validity_writable"
+    )]
     /// Ensure the validity slice is writable.
     ///
     /// # SAFETY
diff --git a/vortex-error/src/lib.rs b/vortex-error/src/lib.rs
@@ -28,12 +28,18 @@ use std::sync::PoisonError;
 #[derive(Debug)]
 pub struct ErrString(Cow<'static, str>);
 
-#[allow(clippy::fallible_impl_from)]
+#[expect(
+    clippy::fallible_impl_from,
+    reason = "intentionally panic in debug mode when VORTEX_PANIC_ON_ERR is set"
+)]
 impl<T> From<T> for ErrString
 where
     T: Into<Cow<'static, str>>,
 {
-    #[allow(clippy::panic)]
+    #[expect(
+        clippy::panic,
+        reason = "intentionally panic in debug mode when VORTEX_PANIC_ON_ERR is set"
+    )]
     fn from(msg: T) -> Self {
         if env::var("VORTEX_PANIC_ON_ERR").as_deref().unwrap_or("") == "1" {
             panic!("{}\nBacktrace:\n{}", msg.into(), Backtrace::capture());
diff --git a/vortex-io/src/io_buf.rs b/vortex-io/src/io_buf.rs
@@ -446,7 +446,10 @@ mod tests {
     #[should_panic(expected = "Invalid range")]
     fn test_owned_slice_invalid_range() {
         let data = vec![1, 2, 3];
-        #[allow(clippy::reversed_empty_ranges)]
+        #[expect(
+            clippy::reversed_empty_ranges,
+            reason = "intentionally testing invalid range"
+        )]
         data.slice_owned(5..3); // start > end
     }
 
diff --git a/vortex-jni/src/array.rs b/vortex-jni/src/array.rs
@@ -63,7 +63,10 @@ impl NativeArray {
         unsafe { Box::from_raw(pointer as *mut NativeArray) }
     }
 
-    #[allow(clippy::expect_used)]
+    #[expect(
+        clippy::expect_used,
+        reason = "JNI contract guarantees non-null pointer"
+    )]
     pub unsafe fn from_ptr<'a>(pointer: jlong) -> &'a Self {
         unsafe {
             (pointer as *const NativeArray)
diff --git a/vortex-jni/src/array_iter.rs b/vortex-jni/src/array_iter.rs
@@ -26,7 +26,10 @@ impl NativeArrayIterator {
         Box::into_raw(self) as jlong
     }
 
-    #[allow(clippy::expect_used)]
+    #[expect(
+        clippy::expect_used,
+        reason = "JNI contract guarantees non-null pointer"
+    )]
     pub unsafe fn from_ptr<'a>(pointer: jlong) -> &'a Self {
         unsafe {
             (pointer as *const NativeArrayIterator)
@@ -35,7 +38,10 @@ impl NativeArrayIterator {
         }
     }
 
-    #[allow(clippy::expect_used)]
+    #[expect(
+        clippy::expect_used,
+        reason = "JNI contract guarantees non-null pointer"
+    )]
     pub unsafe fn from_ptr_mut<'a>(pointer: jlong) -> &'a mut Self {
         unsafe {
             (pointer as *mut NativeArrayIterator)
diff --git a/vortex-jni/src/errors.rs b/vortex-jni/src/errors.rs
@@ -79,7 +79,10 @@ impl JNIDefault for jobject {
 }
 
 /// Run the provided function inside the JNIEnv context. Throws an exception if the function returns an error.
-#[allow(clippy::expect_used)]
+#[expect(
+    clippy::expect_used,
+    reason = "JNI operations must succeed for proper error handling"
+)]
 #[inline]
 pub fn try_or_throw<'a, F, T>(env: &mut JNIEnv<'a>, function: F) -> T
 where
diff --git a/vortex-jni/src/file.rs b/vortex-jni/src/file.rs
@@ -57,7 +57,10 @@ impl NativeFile {
         unsafe { Box::from_raw(pointer as *mut NativeFile) }
     }
 
-    #[allow(clippy::expect_used)]
+    #[expect(
+        clippy::expect_used,
+        reason = "JNI contract guarantees non-null pointer"
+    )]
     pub unsafe fn from_ptr<'a>(pointer: jlong) -> &'a Self {
         unsafe {
             (pointer as *const NativeFile)
diff --git a/vortex-jni/src/logging.rs b/vortex-jni/src/logging.rs
diff --git a/vortex-jni/src/writer.rs b/vortex-jni/src/writer.rs
diff --git a/vortex-scalar/src/decimal/scalar.rs b/vortex-scalar/src/decimal/scalar.rs
diff --git a/vortex-scalar/src/pvalue.rs b/vortex-scalar/src/pvalue.rs
diff --git a/vortex-scan/src/repeated_scan.rs b/vortex-scan/src/repeated_scan.rs
diff --git a/vortex-vector/src/binaryview/view.rs b/vortex-vector/src/binaryview/view.rs
diff --git a/vortex-vector/src/decimal/vector_mut.rs b/vortex-vector/src/decimal/vector_mut.rs
diff --git a/vortex-vector/src/primitive/vector_mut.rs b/vortex-vector/src/primitive/vector_mut.rs
diff --git a/vortex-vector/src/vector.rs b/vortex-vector/src/vector.rs
diff --git a/vortex-vector/src/vector_mut.rs b/vortex-vector/src/vector_mut.rs

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,10 @@ impl CanonicalVTable<FSSTVTable> for FSSTVTable {`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`
`53`		`-#[allow(clippy::cast_possible_truncation)]`
	`53`	`+#[expect(`
	`54`	`+ clippy::cast_possible_truncation,`
	`55`	`+ reason = "truncation is intentional for buffer index"`
	`56`	`+)]`
`54`	`57`	`fn fsst_decode_views(fsst_array: &FSSTArray, buf_index: u32) -> (ByteBuffer, Buffer<BinaryView>) {`
`55`	`58`	`// FSSTArray has two child arrays:`
`56`	`59`	`// 1. A VarBinArray, which holds the string heap of the compressed codes.`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,10 @@ impl CanonicalVTable<SparseVTable> for SparseVTable {`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`
`118`		`-#[allow(clippy::cognitive_complexity)]`
	`118`	`+#[expect(`
	`119`	`+ clippy::cognitive_complexity,`
	`120`	`+ reason = "complexity is from nested match_smallest_offset_type macro"`
	`121`	`+)]`
`119`	`122`	`fn canonicalize_sparse_lists(`
`120`	`123`	`array: &SparseArray,`
`121`	`124`	`values_dtype: Arc<DType>,`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,6 @@ impl PrimitiveArray {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`/// Try to extract a mutable buffer from the PrimitiveArray with zero copy.`
`113`		`- #[allow(clippy::panic_in_result_fn)]`
`114`	`113`	`pub fn try_into_buffer_mut<T: NativePType>(self) -> Result<BufferMut<T>, PrimitiveArray> {`
`115`	`114`	`if T::PTYPE != self.ptype() {`
`116`	`115`	`vortex_panic!(`