wip

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Author: joseph-isaacs

vortex-array/src/array/mod.rs

@@ -655,20 +655,20 @@ impl<V: VTable> ArrayEq for ArrayAdapter<V> {
 }
 
 impl<V: VTable> ArrayVisitor for ArrayAdapter<V> {
-    fn children(&self) -> Vec<&dyn Array> {
+    fn children<'a>(&'a self) -> Vec<&'a dyn Array> {
         // FIXME(ji/node-trav-for-arr): This implementation has issues with lifetime management.
         // The visitor pattern gives us &dyn Array with scoped lifetimes, but we need to return
         // Vec<&dyn Array> with references that outlive this function. Current approaches:
         // 1. Box::leak - works but leaks memory (current impl)
         // 2. Unsafe transmute - UB for dynamically-constructed children (e.g., ChunkedArray's chunk_offsets)
         // 3. Change signature to iterator-based API
-        struct ChildrenCollector {
-            children: Vec<ArrayRef>,
+        struct ChildrenCollector<'a> {
+            children: Vec<&'a dyn Array>,
         }
 
-        impl<'a> ArrayChildVisitor<'a> for ChildrenCollector {
+        impl<'a> ArrayChildVisitor<'a> for ChildrenCollector<'a> {
             fn visit_child(&mut self, _name: &str, array: &'a dyn Array) {
-                self.children.push(array.to_array());
+                self.children.push(array);
             }
         }
 
@@ -677,15 +677,7 @@ impl<V: VTable> ArrayVisitor for ArrayAdapter<V> {
         };
         <V::VisitorVTable as VisitorVTable<V>>::visit_children(&self.0, &mut collector);
 
-        // Use Box::leak to extend lifetime - THIS LEAKS MEMORY!
-        collector
-            .children
-            .into_iter()
-            .map(|arc| {
-                let leaked: &'static Arc<dyn Array> = Box::leak(Box::new(arc));
-                leaked.as_ref() as &dyn Array
-            })
-            .collect()
+        collector.children
     }
 
     fn visit_children<'a>(&'a self, visitor: &mut dyn ArrayChildVisitor<'a>) {