Skip to content

Remove Failing Deviation Unit Test #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2022
Merged

Remove Failing Deviation Unit Test #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f9fe9d
remove division by 0 in unit deviation test
ElliotFriedman Aug 3, 2022
dd7ca6e
ensure both x and y are non zero
ElliotFriedman Aug 3, 2022
d9a1264
remove failing fuzz unit test
ElliotFriedman Aug 3, 2022
bec5f75
remove block numbers from package.json
ElliotFriedman Aug 3, 2022
270f0e8
remove block numbers from package.json
ElliotFriedman Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions contracts/test/unit/utils/Deviation.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ contract UnitTestDeviation is DSTest {
);
}

function testWithinDeviationFuzz(int128 x, int128 y) public view {
maxDeviationThresholdBasisPoints.isWithinDeviationThreshold(x, y);
}

function testOutsideDeviation() public {
int256 x = 275000;
int256 y = 577500;
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"test": "forge test --match-contract UnitTest -vvv",
"test:proposal:mainnet": "forge test --fork-url https://eth-mainnet.alchemyapi.io/v2/$MAINNET_ALCHEMY_API_KEY --match-test testProposalMainnet -vvv",
"test:proposal:arbitrum": "forge test --fork-url https://arb-mainnet.g.alchemy.com/v2/$ARBITRUM_ALCHEMY_API_KEY --match-test testProposalArbitrum -vvv",
"test:integration": "FORK_BLOCK=15220981; forge test --fork-url https://eth-mainnet.alchemyapi.io/v2/$MAINNET_ALCHEMY_API_KEY --fork-block-number $FORK_BLOCK --match-contract IntegrationTest -vvv",
"test:integration:arbitrum": "FORK_BLOCK=18348347; forge test --fork-url https://arb-mainnet.g.alchemy.com/v2/$ARBITRUM_ALCHEMY_API_KEY --fork-block-number $FORK_BLOCK --match-contract ArbitrumTest -vvv",
"test:integration": "forge test --fork-url https://eth-mainnet.alchemyapi.io/v2/$MAINNET_ALCHEMY_API_KEY --match-contract IntegrationTest -vvv",
"test:integration:arbitrum": "forge test --fork-url https://arb-mainnet.g.alchemy.com/v2/$ARBITRUM_ALCHEMY_API_KEY --match-contract ArbitrumTest -vvv",
"lint": "npm run lint:ts && npm run lint:sol",
"lint:ts": "eslint --config ./.eslintrc --ignore-path ./.eslintignore --ext .ts,.tsx .",
"lint-all": "eslint --config ./.eslintrc --ignore-path ./.eslintignore --ext .js,.jsx,.ts,.tsx .",
Expand Down