fix: fix builtintooltrace (#121)

* Add docstring to builtintools

* Add buildin tool span.

---------

Co-authored-by: wangjiaju.716 <wangjiaju.716@bytedance.com>

Author: doraemonlove

config.yaml.full

@@ -16,6 +16,18 @@ model:
     dim: 2560
     api_base: https://ark.cn-beijing.volces.com/api/v3/embeddings
     api_key:
+  video:
+    name: doubao-seedance-1-0-pro-250528
+    api_base: https://ark.cn-beijing.volces.com/api/v3/
+    api_key: 
+  image:
+    name: doubao-seedream-3-0-t2i-250415
+    api_base: https://ark.cn-beijing.volces.com/api/v3/
+    api_key: 
+  edit:
+    name: doubao-seededit-3-0-i2i-250628
+    api_base: https://ark.cn-beijing.volces.com/api/v3/
+    api_key: 
 
 volcengine:
   # [optional] for Viking DB and `web_search` tool

veadk/tools/builtin_tools/image_edit.py

@@ -11,84 +11,226 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
 from typing import Dict
 from google.adk.tools import ToolContext
 from google.genai import types
 from volcenginesdkarkruntime import Ark
 from veadk.config import getenv
 import base64
-
+from opentelemetry import trace
+import traceback
+import json
+from veadk.version import VERSION
+from opentelemetry.trace import Span
 from veadk.utils.logger import get_logger
 
 logger = get_logger(__name__)
 
 client = Ark(
-    api_key=getenv("MODEL_IMAGE_API_KEY"),
-    base_url=getenv("MODEL_IMAGE_API_BASE"),
+    api_key=getenv("MODEL_EDIT_API_KEY"),
+    base_url=getenv("MODEL_EDIT_API_BASE"),
 )
 
 
 async def image_edit(
-    origin_image: str,
-    image_name: str,
-    image_prompt: str,
-    response_format: str,
-    guidance_scale: float,
-    watermark: bool,
-    seed: int,
+    params: list,
     tool_context: ToolContext,
 ) -> Dict:
-    """Edit an image accoding to the prompt.
+    """
+    Edit images in batch according to prompts and optional settings.
+
+    Each item in `params` describes a single image-edit request.
 
     Args:
-        origin_image: The url or the base64 string of the edited image.
-        image_name: The name of the generated image.
-        image_prompt: The prompt that describes the image.
-        response_format: str, b64_json or url, default url.
-        guidance_scale: default 2.5.
-        watermark: default True.
-        seed: default -1.
+        params (list[dict]):
+            A list of image editing requests. Each item supports:
+
+            Required:
+                - origin_image (str):
+                    The URL or Base64 string of the original image to edit.
+                    Example:
+                      * URL: "https://example.com/image.png"
+                      * Base64: "data:image/png;base64,<BASE64>"
+
+                - prompt (str):
+                    The textual description/instruction for editing the image.
+                    Supports English and Chinese.
+
+            Optional:
+                - image_name (str):
+                    Name/identifier for the generated image.
 
+                - response_format (str):
+                    Format of the returned image.
+                    * "url": JPEG link (default)
+                    * "b64_json": Base64 string in JSON
+
+                - guidance_scale (float):
+                    How strongly the prompt affects the result.
+                    Range: [1.0, 10.0], default 2.5.
+
+                - watermark (bool):
+                    Whether to add watermark.
+                    Default: True.
+
+                - seed (int):
+                    Random seed for reproducibility.
+                    Range: [-1, 2^31-1], default -1 (random).
+
+    Returns:
+        Dict: API response containing generated image metadata.
+        Example:
+        {
+            "status": "success",
+            "success_list": [{"image_name": ""}],
+            "error_list": [{}]
+        }
+
+    Notes:
+        - Uses SeedEdit 3.0 model.
+        - Provide the same `seed` for consistent outputs across runs.
+        - A high `guidance_scale` enforces stricter adherence to text prompt.
     """
-    try:
-        response = client.images.generate(
-            model=getenv("MODEL_EDIT_NAME"),
-            image=origin_image,
-            prompt=image_prompt,
-            response_format=response_format,
-            guidance_scale=guidance_scale,
-            watermark=watermark,
-            seed=seed,
-        )
-
-        if response.data and len(response.data) > 0:
-            for item in response.data:
-                if response_format == "url":
-                    image = item.url
-                    tool_context.state["generated_image_url"] = image
-
-                elif response_format == "b64_json":
-                    image = item.b64_json
-                    image_bytes = base64.b64decode(image)
-
-                    tool_context.state["generated_image_url"] = (
-                        f"data:image/jpeg;base64,{image}"
-                    )
-
-                    report_artifact = types.Part.from_bytes(
-                        data=image_bytes, mime_type="image/png"
-                    )
-                    await tool_context.save_artifact(image_name, report_artifact)
-                    logger.debug(f"Image saved as ADK artifact: {image_name}")
-
-                return {"status": "success", "image_name": image_name, "image": image}
-        else:
-            error_details = f"No images returned by Doubao model: {response}"
+    success_list = []
+    error_list = []
+    for idx, item in enumerate(params):
+        image_name = item.get("image_name", f"generated_image_{idx}")
+        prompt = item.get("prompt")
+        origin_image = item.get("origin_image")
+        response_format = item.get("response_format", "url")
+        guidance_scale = item.get("guidance_scale", 2.5)
+        watermark = item.get("watermark", True)
+        seed = item.get("seed", -1)
+
+        try:
+            tracer = trace.get_tracer("gcp.vertex.agent")
+            with tracer.start_as_current_span("call_llm") as span:
+                inputs = {
+                    "prompt": prompt,
+                    "image": origin_image,
+                    "response_format": response_format,
+                    "guidance_scale": guidance_scale,
+                    "watermark": watermark,
+                    "seed": seed,
+                }
+                input_part = {
+                    "role": "user",
+                    "content": json.dumps(inputs, ensure_ascii=False),
+                }
+                response = client.images.generate(
+                    model=getenv("MODEL_EDIT_NAME"), **inputs
+                )
+                output_part = None
+                if response.data and len(response.data) > 0:
+                    for item in response.data:
+                        if response_format == "url":
+                            image = item.url
+                            tool_context.state[f"{image_name}_url"] = image
+                            output_part = {
+                                "message.role": "model",
+                                "message.content": image,
+                            }
+                        elif response_format == "b64_json":
+                            image = item.b64_json
+                            image_bytes = base64.b64decode(image)
+
+                            tool_context.state[f"{image_name}_url"] = (
+                                f"data:image/jpeg;base64,{image}"
+                            )
+
+                            report_artifact = types.Part.from_bytes(
+                                data=image_bytes, mime_type="image/png"
+                            )
+                            await tool_context.save_artifact(
+                                image_name, report_artifact
+                            )
+                            logger.debug(f"Image saved as ADK artifact: {image_name}")
+
+                        success_list.append({image_name: image})
+                else:
+                    error_details = f"No images returned by Doubao model: {response}"
+                    logger.error(error_details)
+                    error_list.append(image_name)
+
+                add_span_attributes(
+                    span,
+                    tool_context,
+                    input_part=input_part,
+                    output_part=output_part,
+                    output_tokens=response.usage.output_tokens,
+                    total_tokens=response.usage.total_tokens,
+                    request_model=getenv("MODEL_EDIT_NAME"),
+                    response_model=getenv("MODEL_EDIT_NAME"),
+                )
+
+        except Exception as e:
+            error_details = f"No images returned by Doubao model: {e}"
             logger.error(error_details)
-            return {"status": "error", "message": error_details}
+            traceback.print_exc()
+            error_list.append(image_name)
 
-    except Exception as e:
+    if len(success_list) == 0:
         return {
             "status": "error",
-            "message": f"Doubao image generation failed: {str(e)}",
+            "success_list": success_list,
+            "error_list": error_list,
+        }
+    else:
+        return {
+            "status": "success",
+            "success_list": success_list,
+            "error_list": error_list,
         }
+
+
+def add_span_attributes(
+    span: Span,
+    tool_context: ToolContext,
+    input_part: dict = None,
+    output_part: dict = None,
+    input_tokens: int = None,
+    output_tokens: int = None,
+    total_tokens: int = None,
+    request_model: str = None,
+    response_model: str = None,
+):
+    try:
+        # common attributes
+        app_name = tool_context._invocation_context.app_name
+        user_id = tool_context._invocation_context.user_id
+        agent_name = tool_context.agent_name
+        session_id = tool_context._invocation_context.session.id
+        span.set_attribute("gen_ai.agent.name", agent_name)
+        span.set_attribute("openinference.instrumentation.veadk", VERSION)
+        span.set_attribute("gen_ai.app.name", app_name)
+        span.set_attribute("gen_ai.user.id", user_id)
+        span.set_attribute("gen_ai.session.id", session_id)
+        span.set_attribute("agent_name", agent_name)
+        span.set_attribute("agent.name", agent_name)
+        span.set_attribute("app_name", app_name)
+        span.set_attribute("app.name", app_name)
+        span.set_attribute("user.id", user_id)
+        span.set_attribute("session.id", session_id)
+        span.set_attribute("cozeloop.report.source", "veadk")
+
+        # llm attributes
+        span.set_attribute("gen_ai.system", "openai")
+        span.set_attribute("gen_ai.operation.name", "chat")
+        if request_model:
+            span.set_attribute("gen_ai.request.model", request_model)
+        if response_model:
+            span.set_attribute("gen_ai.response.model", response_model)
+        if total_tokens:
+            span.set_attribute("gen_ai.usage.total_tokens", total_tokens)
+        if output_tokens:
+            span.set_attribute("gen_ai.usage.output_tokens", output_tokens)
+        if input_tokens:
+            span.set_attribute("gen_ai.usage.input_tokens", input_tokens)
+        if input_part:
+            span.add_event("gen_ai.user.message", input_part)
+        if output_part:
+            span.add_event("gen_ai.choice", output_part)
+
+    except Exception:
+        traceback.print_exc()