Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: fix all golint issue #821

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

daixiang0
Copy link
Contributor

Signed-off-by: Xiang Dai long0dai@foxmail.com

Signed-off-by: Xiang Dai <long0dai@foxmail.com>
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @daixiang0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 46170d10-9a6d-11ea-ae6f-3d1c6927e18c

Signed-off-by: Xiang Dai <long0dai@foxmail.com>
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@hzxuzhonghu hzxuzhonghu added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: daixiang0, hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 9034da9 into volcano-sh:master May 21, 2020
@daixiang0 daixiang0 deleted the golint branch May 21, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants