Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prepare-for-development doc #3150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hzq5477
Copy link

@hzq5477 hzq5477 commented Oct 8, 2023

I ran into several issues when I was trying to develop on my Mac, so I think it's better to update it in case it happens again for future contributors:

  1. At first, I set up everything on my Mac which has an ARM64 chip. While it works on the sample, there are some parts of the unit tests kept failing, so I added Recommended Operating Systems to ask Mac developers to have a virtual machine.
  2. Update the Go version in the doc.
  3. Replace a wrong project name (Istio) with Volcano.
  4. Change the link for installing docker, the original one is to install docker desktop while the docker engine is enough.

@volcano-sh-bot
Copy link
Contributor

Welcome @hzq5477!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2023
Signed-off-by: hzq5477 <qirin@MacBook-Air-335.local>
@hzq5477 hzq5477 force-pushed the fix-prepare-for-development-doc branch from 64b737e to ff4c77d Compare October 8, 2023 21:34
@lowang-bh
Copy link
Member

/lgtm

Thanks for your contributions!

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
Copy link

stale bot commented Dec 15, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2023
@stale stale bot closed this Mar 17, 2024
@lowang-bh
Copy link
Member

/reopen

@volcano-sh-bot
Copy link
Contributor

@lowang-bh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale stale bot removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2024
@lowang-bh
Copy link
Member

lowang-bh commented Mar 17, 2024

/assign @Monokaix
plz help to merge it.

@Monokaix
Copy link
Member

/assign @Monokaix plz help to merge it.

Which part of ut failed, is OS problem or ut itself?

@lowang-bh
Copy link
Member

/assign @Monokaix plz help to merge it.

Which part of ut failed, is OS problem or ut itself?

"there are some parts of the unit tests kept failing"

As I known, the gomonkey package has no permit to run on MAC.

@Monokaix
Copy link
Member

/assign @Monokaix plz help to merge it.

Which part of ut failed, is OS problem or ut itself?

"there are some parts of the unit tests kept failing"

As I known, the gomonkey package has no permit to run on MAC.

Has gomonkey been replaced after your ut refactor pr?

@lowang-bh
Copy link
Member

As I known, the gomonkey package has no permit to run on MAC.

Has gomonkey been replaced after your ut refactor pr?

Yes, it is not necessary now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants