Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event/Action should be shared by Job & Queue #680

Closed
k82cn opened this issue Jan 28, 2020 · 1 comment
Closed

Event/Action should be shared by Job & Queue #680

k82cn opened this issue Jan 28, 2020 · 1 comment
Assignees
@k82cn
Labels
area/controllers kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
v0.4

Comments

@k82cn
Copy link
Member

k82cn commented Jan 28, 2020

Is this a BUG REPORT or FEATURE REQUEST?:

/kind cleanup

What happened:

Currently, we have JobEvent/QueueEvent, JobAction/QueueAction, but most of them are similar. prefer to combine them into Event/Action to avoid duplication.
@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 28, 2020
@k82cn k82cn added area/controllers kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jan 28, 2020
@k82cn k82cn added this to the v0.4 milestone Jan 28, 2020
@k82cn k82cn self-assigned this Jan 28, 2020
@k82cn
Copy link
Member Author

k82cn commented Jan 28, 2020

fixed by #681

@k82cn k82cn closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k82cn k82cn

Labels
area/controllers kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
2 participants
@k82cn @volcano-sh-bot