Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync combine input & output volumes into array logic. #122

Closed
TommyLike opened this issue May 5, 2019 · 3 comments
Closed

Sync combine input & output volumes into array logic. #122

TommyLike opened this issue May 5, 2019 · 3 comments
Assignees
@TommyLike
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high
Milestone
v0.1

Comments

@TommyLike
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

During main logic sync, the change of combine input & output feature is partially synced due to the code merge conflict, need fix and reenable it.

See

volcano/pkg/admission/admit_job.go

Line 147 in d9b532c

//TODO(tommylikehu): Fix me and enable it.

@TommyLike
Copy link
Contributor Author

/assign

@TommyLike TommyLike self-assigned this May 5, 2019
@TommyLike TommyLike mentioned this issue May 5, 2019
Merged
@k82cn k82cn added this to the v0.1 milestone May 6, 2019
@k82cn
Copy link
Member

k82cn commented May 6, 2019

/kind feature
/priority high

@volcano-sh-bot volcano-sh-bot added kind/feature Categorizes issue or PR as related to a new feature. priority/high labels May 6, 2019
@TommyLike
Copy link
Contributor Author

Done in #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TommyLike TommyLike

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/high
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
3 participants
@TommyLike @k82cn @volcano-sh-bot