Skip to content

Fix PHP 8.4 deprecation warnings #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

TomA-R
Copy link

@TomA-R TomA-R commented Dec 7, 2024

Fixes warnings like:

Deprecated: Stringy\Stringy::__construct(): Implicitly marking parameter $encoding as nullable is deprecated, the explicit nullable type must be used instead in Stringy/src/Stringy.php on line 77
Deprecated: Stringy\Stringy::between(): Implicitly marking parameter $offset as nullable is deprecated, the explicit nullable type must be used instead in Stringy/src/Stringy.php on line 601
Deprecated: Stringy\Stringy::create(): Implicitly marking parameter $encoding as nullable is deprecated, the explicit nullable type must be used instead in Stringy/src/Stringy.php on line 957
Deprecated: Stringy\Stringy::extractText(): Implicitly marking parameter $length as nullable is deprecated, the explicit nullable type must be used instead in Stringy/src/Stringy.php on line 1324
Deprecated: Stringy\Stringy::lineWrap(): Implicitly marking parameter $delimiter as nullable is deprecated, the explicit nullable type must be used instead in Stringy/src/Stringy.php on line 2652
Deprecated: Stringy\Stringy::lineWrapAfterWord(): Implicitly marking parameter $delimiter as nullable is deprecated, the explicit nullable type must be used instead in Stringy/src/Stringy.php on line 2691

..and more

cc @voku for your review


This change is Reviewable

Copy link

sonarqubecloud bot commented Dec 7, 2024

@TomA-R TomA-R marked this pull request as ready for review December 7, 2024 12:20
@JasonStainton
Copy link

+1 getting this pushed through. I've never seen so many deprecations warnings 😅

@Elnadrion
Copy link

Same here. @voku could you please consider merging it? 🙏

@Anubarak
Copy link

@voku Are there any plans to merge it in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants