Skip to content

Commit 1be3ae7

Browse files
Merge pull request qntln#2 from vojty/hotfix/new-element-z-index
Keep defined RenderLayer zIndex
2 parents 2b5d7c6 + 5ff6db3 commit 1be3ae7

File tree

6 files changed

+8
-14
lines changed

6 files changed

+8
-14
lines changed

.eslintrc.js

-9
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,5 @@ module.exports = {
66
node: true
77
},
88
plugins: ["prettier", "react"],
9-
rules: {
10-
"prettier/prettier": "error",
11-
"prefer-const": "error",
12-
"no-use-before-define": "error",
13-
"no-var": "error",
14-
"no-throw-literal": "error",
15-
// Light console usage is useful but remove debug logs before merging to master.
16-
"no-console": "off"
17-
},
189
extends: ["prettier", "plugin:react/recommended", "eslint:recommended"]
1910
};

.gitignore

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ node_modules
22
npm-debug.log
33
.idea
44
storybook-static
5-
dist
5+
dist
6+
yarn-error.log

package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
"build": "rimraf dist && babel src --out-dir dist",
1212
"storybook": "start-storybook -p 6006 -c .storybook",
1313
"build-storybook": "build-storybook -c .storybook",
14-
"prepare": "yarn build"
14+
"prepare": "yarn build",
15+
"prettier": "prettier src/**/* --write",
16+
"lint": "eslint src/**/*"
1517
},
1618
"keywords": [
1719
"react",

src/CanvasRenderer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ CanvasRenderer.injectIntoDevTools({
212212
version: React.version || 16,
213213
rendererPackageName: "react-canvas",
214214
getInspectorDataForViewTag: (...args) => {
215-
console.log(args);
215+
console.log(args); // eslint-disable-line no-console
216216
}
217217
});
218218

src/DrawingUtils.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ drawRenderLayer = (ctx, layer) => {
405405
if (saveContext) {
406406
ctx.restore();
407407
}
408-
}
408+
};
409409

410410
/**
411411
* Draw a bitmap-cacheable layer into a pooled <canvas>. The result will be

src/RenderLayer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ RenderLayer.prototype = {
8383
const beforeIndex = parentLayer.children.indexOf(beforeLayer);
8484
parentLayer.children.splice(beforeIndex, 0, this);
8585
this.parentLayer = parentLayer;
86-
this.zIndex = beforeLayer.zIndex || 0;
86+
this.zIndex = this.zIndex || beforeLayer.zIndex || 0;
8787
},
8888

8989
/**

0 commit comments

Comments
 (0)