-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support generic bounds #389
base: main
Are you sure you want to change the base?
Conversation
@olegshtch thanks for this nice PR. |
837f0c0
to
bb80aec
Compare
Looks like #380 isn't fixed with this PR. |
bb80aec
to
46a55f9
Compare
Rebased. Removed test for #380. |
@olegshtch I pushed fix for #380 - c231299 |
@vojtechhabarta I suppose generic bounds wasn't part of this commit? |
No, I think it is separate thing. |
Is something left to do in this PR? |
I am not sure if this feature has high enough value to justify the change in generated output. |
We use a narrowing of types in a production Java code so prefer to have it in a TypeScript. Something like |
Maybe add a new option to enable it? |
In general I prefer not to add new parameters because it is becoming harder for users to go through all typescript-generator parameters. Currently typescript-generator outputs interface Response {
message: Message<HumanBody>;
}
interface HumanBody extends Body {
} So when there is a JSON with |
46a55f9
to
458a63c
Compare
458a63c
to
085e5b3
Compare
Rebased |
Allows to use generate extends bound on generic types.