fix(js_runtime): show descriptive message in download progress bar

Display what is being downloaded (e.g., "Downloading Node.js v22.13.1...")
above the progress bar so users understand what the download is for.

Author: fengmk2

crates/vite_js_runtime/src/download.rs

@@ -29,7 +29,14 @@ pub struct CachedFetchResponse {
 }
 
 /// Download a file with retry logic and progress bar
-pub async fn download_file(url: &str, target_path: &AbsolutePath) -> Result<(), Error> {
+///
+/// The `message` parameter is displayed to the user to indicate what is being downloaded
+/// (e.g., "Downloading Node.js v22.13.1").
+pub async fn download_file(
+    url: &str,
+    target_path: &AbsolutePath,
+    message: &str,
+) -> Result<(), Error> {
     tracing::debug!("Downloading {url} to {target_path:?}");
 
     let response = (|| async { reqwest::get(url).await?.error_for_status() })
@@ -45,13 +52,6 @@ pub async fn download_file(url: &str, target_path: &AbsolutePath) -> Result<(),
     // Get Content-Length for progress bar
     let total_size = response.content_length();
 
-    // Extract filename for display
-    let filename = target_path
-        .as_path()
-        .file_name()
-        .map(|s| s.to_string_lossy().to_string())
-        .unwrap_or_else(|| "file".to_string());
-
     // Create progress bar (only in TTY and not in CI)
     let is_ci = std::env::var("CI").is_ok();
     let progress = if std::io::stderr().is_terminal() && !is_ci {
@@ -61,7 +61,7 @@ pub async fn download_file(url: &str, target_path: &AbsolutePath) -> Result<(),
                 pb.set_style(
                     ProgressStyle::default_bar()
                         .template(
-                            "{spinner:.green} [{elapsed_precise}] [{bar:40.cyan/blue}] \
+                            "{msg}\n{spinner:.green} [{elapsed_precise}] [{bar:40.cyan/blue}] \
                              {bytes}/{total_bytes} ({bytes_per_sec}, {eta})",
                         )
                         .expect("valid progress bar template")
@@ -74,15 +74,15 @@ pub async fn download_file(url: &str, target_path: &AbsolutePath) -> Result<(),
                 pb.set_style(
                     ProgressStyle::default_spinner()
                         .template(
-                            "{spinner:.green} [{elapsed_precise}] {bytes} ({bytes_per_sec}) {msg}",
+                            "{msg}\n{spinner:.green} [{elapsed_precise}] {bytes} ({bytes_per_sec})",
                         )
                         .expect("valid spinner template"),
                 );
                 pb.enable_steady_tick(Duration::from_millis(100));
                 pb
             }
         };
-        pb.set_message(format!("Downloading {filename}"));
+        pb.set_message(message.to_string());
         Some(pb)
     } else {
         None
@@ -103,7 +103,7 @@ pub async fn download_file(url: &str, target_path: &AbsolutePath) -> Result<(),
     file.flush().await?;
 
     if let Some(pb) = progress {
-        pb.finish_with_message(format!("Downloaded {filename}"));
+        pb.finish_and_clear();
     }
 
     tracing::debug!("Download completed: {target_path:?}");

crates/vite_js_runtime/src/runtime.rs

@@ -111,7 +111,6 @@ pub async fn download_runtime_with_provider<P: JsRuntimeProvider>(
     let cache_dir = crate::cache::get_cache_dir()?;
 
     // Get paths from provider
-    let platform_str = provider.platform_string(platform);
     let binary_relative_path = provider.binary_relative_path(platform);
     let bin_dir_relative_path = provider.bin_dir_relative_path(platform);
 
@@ -139,7 +138,8 @@ pub async fn download_runtime_with_provider<P: JsRuntimeProvider>(
         tokio::fs::remove_dir_all(&install_dir).await?;
     }
 
-    tracing::info!("Downloading {} {version} for {platform_str}...", provider.name());
+    let download_message = format!("Downloading {} v{version}...", provider.name());
+    tracing::info!("{download_message}");
 
     // Get download info from provider
     let download_info = provider.get_download_info(version, platform);
@@ -159,15 +159,15 @@ pub async fn download_runtime_with_provider<P: JsRuntimeProvider>(
                 provider.parse_shasums(&shasums_content, &download_info.archive_filename)?;
 
             // Download archive
-            download_file(&download_info.archive_url, &archive_path).await?;
+            download_file(&download_info.archive_url, &archive_path, &download_message).await?;
 
             // Verify hash
             verify_file_hash(&archive_path, &expected_hash, &download_info.archive_filename)
                 .await?;
         }
         HashVerification::None => {
             // Download archive without verification
-            download_file(&download_info.archive_url, &archive_path).await?;
+            download_file(&download_info.archive_url, &archive_path, &download_message).await?;
         }
     }