Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Git Bash Support #65

Open
pke opened this issue Feb 21, 2020 · 2 comments
Open

Windows Git Bash Support #65

pke opened this issue Feb 21, 2020 · 2 comments

Comments

@pke
Copy link

pke commented Feb 21, 2020

I know its a known bug as per readme, but since there is no issue for it this will be used to keep track of it.

I am not really sure, why the tool claims the Git Bash on Windows has is not a TTY. I am using TTY features all the time ne my own projects. I am using the prompts and similar projects for keyboard navigation just fine there.

So I'll investigate what the problem here might be and provide a PR.
@pke
Copy link
Author

pke commented Feb 21, 2020

Why are you checking the stdout for TTY and not stdin? You need that for keyboard navigation, right?
https://github.com/voidcosmos/npkill/blob/master/src/controller.ts#L220

@KonradLinkowski
Copy link

@zaldih what about using stdin as @pke asked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pke @KonradLinkowski