Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: act-0.2.26 #37174

Merged
merged 1 commit into from
May 20, 2022
Merged

New package: act-0.2.26 #37174

merged 1 commit into from
May 20, 2022

Conversation

0x5c
Copy link
Contributor

@0x5c 0x5c commented May 18, 2022

Testing the changes

  • I tested the changes in this PR: YES

New package

@classabbyamp
Copy link
Member

classabbyamp commented May 18, 2022

adding this adds --version to the act binary (it was very nicely documented, I only found it by looking at the arch pkgbuild):

go_ldflags="-X main.version=${version}"

Would it be good to depend on docker? It may allow for other container backends in the future, but currently it's only docker (nektos/act#303)

@0x5c
Copy link
Contributor Author

0x5c commented May 18, 2022

Would it be good to depend on docker? It may allow for other container backends in the future, but currently it's only docker (nektos/act#303)

Yeah, I was thinking of that, just unsure it would be good to add or not. It does say this when docker is not installed/running

failed to obtain container engine info: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

I wonder if that is enough indication that docker is needed, by void standards.

The version thing is fixed, thanks for spotting that

@paper42 paper42 added the new-package This PR adds a new package label May 18, 2022
@catthehacker
Copy link

It may allow for other container backends in the future, but currently it's only docker (nektos/act#303)

It allows for other container backends already, it just needs to have Docker Engine compatible API and connection option, e.g. DOCKER_HOST=unix:///var/run/podman.sock
https://github.com/nektos/act/wiki/Custom-container-engine

@0x5c
Copy link
Contributor Author

0x5c commented May 19, 2022

It may allow for other container backends in the future, but currently it's only docker (nektos/act#303)

It allows for other container backends already, it just needs to have Docker Engine compatible API and connection option, e.g. DOCKER_HOST=unix:///var/run/podman.sock
https://github.com/nektos/act/wiki/Custom-container-engine

So it wouldn't be a good idea to add a dependency on docker

--

This PR should be ready to merge

@paper42 paper42 merged commit 1fde2c6 into void-linux:master May 20, 2022
@0x5c 0x5c deleted the act branch May 20, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants