Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ginkgo to v2. #8010

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Bump Ginkgo to v2. #8010

merged 1 commit into from
Jul 17, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 12, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7961

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 12, 2024
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-unit-tests has-e2e-2tests labels Jul 12, 2024
@blackpiglet blackpiglet requested a review from ywk253100 July 12, 2024 09:17
@blackpiglet blackpiglet marked this pull request as draft July 12, 2024 10:02
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.82%. Comparing base (3bd8a7d) to head (7a3b947).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8010      +/-   ##
==========================================
- Coverage   58.82%   58.82%   -0.01%     
==========================================
  Files         346      346              
  Lines       28901    28886      -15     
==========================================
- Hits        17002    16993       -9     
+ Misses      10467    10464       -3     
+ Partials     1432     1429       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet
Copy link
Contributor Author

The existing case filters are not working after bumping to v2. All cases are executed, so the tests failed with timeout.
Need to fix #7959 first.

@blackpiglet blackpiglet requested review from Lyndon-Li and removed request for anshulahuja98 July 15, 2024 06:08
Lyndon-Li
Lyndon-Li previously approved these changes Jul 15, 2024
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
@blackpiglet blackpiglet marked this pull request as ready for review July 17, 2024 07:50
@blackpiglet
Copy link
Contributor Author

The existing case filters are not working after bumping to v2. All cases are executed, so the tests failed with timeout. Need to fix #7959 first.

I found the error was caused by the E2E test makefile not updating the Ginkgo version.
After version update, GitHub action tests passed.

@blackpiglet blackpiglet requested a review from sseago July 17, 2024 07:56
@Lyndon-Li Lyndon-Li merged commit 55e0278 into vmware-tanzu:main Jul 17, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-e2e-2tests has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Ginkgo to v2
3 participants