Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying hooks when running velero backup create cli #5861

Open
jhuisss opened this issue Feb 16, 2023 · 1 comment
Open

Specifying hooks when running velero backup create cli #5861

jhuisss opened this issue Feb 16, 2023 · 1 comment
Labels
Icebox We see the value, but it is not slated for the next couple releases. kind/requirement

Comments

@jhuisss
Copy link

jhuisss commented Feb 16, 2023

Describe the problem/challenge you have
is it possible to specify hooks when run velero backup create cli? Instead of annotations on the pod itself or in the Backup spec way provided in https://velero.io/docs/v1.9/backup-hooks/

Describe the solution you'd like
Specifying hooks when run velero backup create cli

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Velero version (use velero version): 1.9.5
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt
Copy link
Contributor

reasonerjt commented Feb 20, 2023

Defining a hook is complicated, I don't think exposing it to CLI is helpful for user experience, it will be error-prone.
I'm putting it to icebox, I don't think we should work on it unless we see strong requirements for this.

@reasonerjt reasonerjt added the Icebox We see the value, but it is not slated for the next couple releases. label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Icebox We see the value, but it is not slated for the next couple releases. kind/requirement
Projects
None yet
Development

No branches or pull requests

2 participants