When remapping namespaces, PVs without snapshots don't get their ClaimRefs remapped.

[sseago]

What steps did you take and what happened:
Restored a PV (without a snapshot) and the PVC it's bound to into a different namespace. The PVC was restored but "pending", with an error that the PV was bound to another claim. The reason for this is that the ClaimRef was not updated to the new namespace. The ClaimRef remapping is only currently done in restore/restore.go when there's a snapshot. It's also needed in the non-snapshot case.

What did you expect to happen:
Expected the PVC restored to the new namespace to be bound to its PV.

The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other pastebin is fine.)

Anything else you would like to add:
Observed this on 1.5.2, but the problem exists on main as well

Environment:

• Velero version (use velero version): 1.5.2
• Kubernetes version (use kubectl version): 1.19
• Cloud provider or hardware configuration: OpenShift on AWS

PR forthcoming, as I have a working local fix.

[sseago]

Related to #2570 and #3007
The earlier PR/issue dealt with this for PVs with snapshots, but not for PVs without them.

[sseago]

PR to fix this is at #3708

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sseago]

Actually, this one shouldn't be considered stale. There's an open PR that fixes the issue currently under review, awaiting feedback from the questions I had asked in response to the first review.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[sseago]

Not stale -- PR has just been updated, but merging is on hold until 1.7 release branch is created.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.