Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

make build-install-cli-local fails if developer has not fetched tags first. #170

Open
1 of 9 tasks
randomvariable opened this issue Jul 13, 2021 · 0 comments
Open
1 of 9 tasks
Labels
area/core-cli area/dx Related to developer experience kind/bug PR/Issue related to a bug
Milestone

Comments

@randomvariable
Copy link
Contributor

Bug description

Running make build-install-cli-local will fail with either pinniped version errors or if artifacts are pre-existing, no new artifacts being built until the developer has ran git fetch upstream to make sure they have the latest tags.

This is because of the Makefile code:

BUILD_VERSION ?= $(shell git describe --tags --abbrev=0 2>$(NUL))
ifeq ($(strip $(BUILD_VERSION)),)
BUILD_VERSION = dev
endif

Affected product area (please put an X in all that apply)

  • APIs
  • Addons
  • CLI
  • Docs
  • Installation
  • Plugin
  • Security
  • Test and Release
  • User Experience

Expected behavior

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

@iancoffey iancoffey self-assigned this Jul 23, 2021
@iancoffey iancoffey added the kind/bug PR/Issue related to a bug label Aug 25, 2021
@iancoffey iancoffey added the retriage Triage, again. label Sep 14, 2021
@iancoffey iancoffey removed their assignment Sep 14, 2021
@vuil vuil added area/dx Related to developer experience and removed retriage Triage, again. labels Oct 19, 2021
@vuil vuil added this to the v.Next milestone Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/core-cli area/dx Related to developer experience kind/bug PR/Issue related to a bug
Projects
None yet
Development

No branches or pull requests

4 participants