Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Docs to configure the Supervisor with a GitHub IDP #1910

Merged
merged 2 commits into from
May 9, 2024
Merged

Add GitHub Docs to configure the Supervisor with a GitHub IDP #1910

merged 2 commits into from
May 9, 2024

Conversation

joshuatcasey
Copy link
Member

Add GitHub Docs

@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.85%. Comparing base (0056764) to head (96e4442).
Report is 50 commits behind head on github_identity_provider.

❗ Current head 96e4442 differs from pull request most recent head f377292. Consider uploading reports for the commit f377292 to get more accurate results

Additional details and impacted files 
@@                     Coverage Diff                      @@
##           github_identity_provider    #1910      +/-   ##
============================================================
- Coverage                     39.03%   29.85%   -9.19%     
============================================================
  Files                           356      357       +1     
  Lines                         45472    59479   +14007     
============================================================
+ Hits                          17751    17756       +5     
- Misses                        27192    41195   +14003     
+ Partials                        529      528       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey changed the title Add GitHub Docs Add GitHub Docs to configure the Supervisor with a GitHub IDP Apr 30, 2024
@joshuatcasey joshuatcasey marked this pull request as ready for review April 30, 2024 14:35
@joshuatcasey
Add docs to configure the Supervisor with a GitHub IDP.
96e4442 
- Does not include docs for configuring GitHub Apps or GitHub OAuth Apps
@cfryanr cfryanr merged commit 3197156 into github_identity_provider May 9, 2024
@cfryanr cfryanr deleted the jtc/github_docs branch May 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

@cfryanr cfryanr cfryanr approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuatcasey @benjaminapetersen @cfryanr @vmwclabot