Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Allow configuration for external-dns to publish metrics #5277

Closed
doddatpivotal opened this issue Aug 23, 2022 · 0 comments · Fixed by #5278
Closed

Allow configuration for external-dns to publish metrics #5277

doddatpivotal opened this issue Aug 23, 2022 · 0 comments · Fixed by #5278
Labels
kind/feature A request for a new feature triage/needs-triage Needs triage by TCE maintainers

Comments

@doddatpivotal
Copy link
Contributor

Feature Request

External-dns can expose metrics. However, in order to configure it to do so, you must set a deployment arg specifying the metrics address, and then add labels to the deployment pods to set appropriate prometheus metrics. The current implementation of the values schema provides ability to set the deployment args, but you can not set the deployment pod labels.

deployment:
  args:
    - --metrics-address=:7979 #! ensures external dns exposes metrics

Describe alternatives you've considered

I have created an overlay to apply the deployment pod labels, but would like to be able to configure observability directly using the values file.

#@ load("@ytt:overlay", "overlay")
#@overlay/match by=overlay.subset({"metadata":{"name":"external-dns"}, "kind": "Deployment"})
---
spec:
  template:
    #@overlay/match missing_ok=True
    metadata:
      #@overlay/match missing_ok=True
      annotations:
        prometheus.io/scrape: "true"
        prometheus.io/path: "/metrics"
        prometheus.io/port: "7979"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature A request for a new feature triage/needs-triage Needs triage by TCE maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant