Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

package public names should be fully qualified #372

Closed
cppforlife opened this issue Mar 24, 2021 · 7 comments · Fixed by #446
Closed

package public names should be fully qualified #372

cppforlife opened this issue Mar 24, 2021 · 7 comments · Fixed by #446
Assignees
Labels
good-first-issue Good for newcomers help-wanted Looking for contributors to help kind/feature A request for a new feature owner/packages Work executed by a package's maintainer
Milestone

Comments

@cppforlife
Copy link
Contributor

cppforlife commented Mar 24, 2021

Feature Request

currently packages have non-qualified public names: cert-manager. instead public names should be following CRD-like naming conventions == fully qualified names.

Current:

apiVersion: package.carvel.dev/v1alpha1
kind: Package
metadata:
  name: fluent-bit.1.7.2-vmware0
spec:
  publicName: fluent-bit
  version: "1.7.2-vmware0"
  # ...

Ideal:

apiVersion: package.carvel.dev/v1alpha1
kind: Package
metadata:
  name: fluent-bit.tce.vmware.com.1.7.2-vmware0
spec:
  publicName: fluent-bit.tce.vmware.com
  version: "1.7.2-vmware0"
  # ...
@cppforlife cppforlife added kind/feature A request for a new feature triage/needs-triage Needs triage by TCE maintainers labels Mar 24, 2021
@rosenhouse
Copy link
Contributor

If package repositories A and B both provide package foo, will this change help a user with disambiguating them?

@jorgemoralespou
Copy link
Contributor

If package repositories A and B both provide package foo, will this change help a user with disambiguating them?

As long as the name is different. This just makes it clear for our conventions.

@cppforlife
Copy link
Contributor Author

If package repositories A and B both provide package foo, will this change help a user with disambiguating them?

yup. foo.corp.com vs foo.blah.com for example.

@joshrosso joshrosso added owner/packages Work executed by a package's maintainer help-wanted Looking for contributors to help good-first-issue Good for newcomers and removed triage/needs-triage Needs triage by TCE maintainers labels Mar 25, 2021
@joshrosso joshrosso added this to the v0.4.0 milestone Mar 25, 2021
@jorgemoralespou
Copy link
Contributor

@joshrosso I'm happy to do this one, but what should be the FQDN to use, as not sure vmware.com should be there, or yes, maybe?

  • tce.vmware.com
  • tce.org
  • tce.io
  • tanzucommunityedition

In the true spirit of community should it have the vmware there?

@rosenhouse
Copy link
Contributor

rosenhouse commented Mar 25, 2021

That question reminds me: how does TCE fit in with the GVK naming convention?

@jorgemoralespou
Copy link
Contributor

@jorgemoralespou
Copy link
Contributor

/assign @jorgemoralespou

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good-first-issue Good for newcomers help-wanted Looking for contributors to help kind/feature A request for a new feature owner/packages Work executed by a package's maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants