Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Expose the -t, --timeout flags in standalone-clusters #1470

Closed
joshrosso opened this issue Aug 26, 2021 · 1 comment · Fixed by #2465
Closed

Expose the -t, --timeout flags in standalone-clusters #1470

joshrosso opened this issue Aug 26, 2021 · 1 comment · Fixed by #2465
Labels
good-first-issue Good for newcomers help-wanted Looking for contributors to help kind/feature A request for a new feature owner/core-eng Work executed by TCE's core engineering team
Milestone

Comments

@joshrosso
Copy link
Contributor

Feature Request

Add the timeout flag to standalone-clusters. This is the same flag used in management-clusters, as seen here:

CreateCmd.Flags().StringVarP(&iso.clusterConfigFile, "file", "f", "", "Configuration file from which to create a standalone cluster")
CreateCmd.Flags().BoolVarP(&iso.ui, "ui", "u", false, "Launch interactive standalone cluster provisioning UI")
CreateCmd.Flags().StringVarP(&iso.infrastructureProvider, "infrastructure", "i", "", "Infrastructure to deploy the standalone cluster on. Only needed when using -i docker.")
CreateCmd.Flags().StringVarP(&iso.bind, "bind", "b", "127.0.0.1:8080", "Specify the IP and port to bind the Kickstart UI against (e.g. 127.0.0.1:8080).")
CreateCmd.Flags().StringVarP(&iso.browser, "browser", "", "", "Specify the browser to open the Kickstart UI on. Use 'none' for no browser. Defaults to OS default browser. Supported: ['chrome', 'firefox', 'safari', 'ie', 'edge', 'none']")

$ tanzu management-cluster create --help
Create a Tanzu Kubernetes Grid management cluster including initializing it with Cluster API components appropriate for the target infrastructure.

Usage:
  tanzu management-cluster create [flags]

Examples:

    # Create a management cluster on AWS infrastructure, initializing it with
    # components required to create workload clusters through it on the same infrastructure
    # by bootstrapping through a self-provisioned bootstrap cluster.
    tanzu management-cluster create --file ~/clusterconfigs/aws-mc-1.yaml
    # Launch an interactive UI to configure the settings necessary to create a
    # management cluster
    tanzu management-cluster create --ui
    # Create a management cluster on vSphere infrastructure by using an existing
    # bootstrapper cluster. The current kube context should point to that
    # of the existing bootstrap cluster.
    tanzu management-cluster create --use-existing-bootstrap-cluster --file vsphere-mc-1.yaml

Flags:
  -b, --bind string                      Specify the IP and port to bind the Kickstart UI against (e.g. 127.0.0.1:8080). (default "127.0.0.1:8080")
      --browser string                   Specify the browser to open the Kickstart UI on. Use 'none' for no browser. Defaults to OS default browser. Supported: ['chrome', 'firefox', 'safari', 'ie', 'edge', 'none']
      --dry-run                          Generates the management cluster manifest and writes the output to stdout without applying it
  -f, --file string                      Configuration file from which to create a management cluster
      --force-config-update              Force an update of all configuration files in ${HOME}/.config/tanzu/tkg/bom and ${HOME}/.tanzu/tkg/compatibility
  -h, --help                             help for create
  -t, --timeout duration                 Time duration to wait for an operation before timeout. Timeout duration in hours(h)/minutes(m)/seconds(s) units or as some combination of them (e.g. 2h, 30m, 2h30m10s) (default 30m0s)
  -u, --ui                               Launch interactive management cluster provisioning UI
  -e, --use-existing-bootstrap-cluster   Use an existing bootstrap cluster to deploy the management cluster
  -y, --yes                              Create management cluster without asking for confirmation

Global Flags:
      --log-file string   Log file path
  -v, --verbose int32     Number for the log level verbosity(0-9)

Describe alternatives you've considered

None

Additional context

None

@joshrosso joshrosso added good-first-issue Good for newcomers help-wanted Looking for contributors to help owner/core-eng Work executed by TCE's core engineering team kind/feature A request for a new feature labels Aug 26, 2021
@joshrosso joshrosso added this to the icebox milestone Aug 26, 2021
@mritunjaysharma394
Copy link
Contributor

Hi @joshrosso , I have worked on a PR to fix this, do review at your good time and let me know for anything else, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good-first-issue Good for newcomers help-wanted Looking for contributors to help kind/feature A request for a new feature owner/core-eng Work executed by TCE's core engineering team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants