Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to set initContainer "setup-ca-certs" resources #120

Open
moandersson opened this issue Dec 5, 2024 · 1 comment
Open

Comments

@moandersson
Copy link

Currently there is no way to modify the manifest of the initContainer that injects the Certificates. We use both ResourceQuotas and OPA Gatekeeper rules that prevents from creating the Pod if the initContainer lacks resource requests and limits. We would really like to avoid using a limitRanger in all our namespaces as this will have other implications, as we want to make users aware they need to configure resource settings and not silently just add a default resource for all containers in a namespace.

I suggest we add the possibility to configure this on the initContainer object via environment variable here: https://github.com/vmware-tanzu/cert-injection-webhook/blob/main/pkg/certinjectionwebhook/admission_controller.go#L227-L248

I do have a branch ready for this, but according to the CONTRIBUTION docs I was suppose to open an issue before opening the Pull request. So here it is :)
08fc149

@moandersson
Copy link
Author

Looks like there is not much activity here, so I went ahead and opened a PR. I hope someone can have a look at it: #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant